Remove 'dark' from document.body.classList when starting interface with dark_theme: false #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th dark_theme: false
|
That's indeed weird, maybe there is a bug in the new gradio version (I recently updated to 4.37). Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem described in issue #6613.
It's likely not fixing the root cause, which would be to not set the class name of the
bodyto 'dark' in the first place whendark_themeis set tofalsein the settings.However, I was unable to determine what causes this behavior, so I simply removed 'dark' from the
classListin the same piece of javascript that adds it whendark_themeistrueat startup.Checklist: