Skip to content

Adjust parsing of headers - #1302

Open
aagbsn wants to merge 1 commit into
masterfrom
client_ip_from_proxy
Open

aagbsn wants to merge 1 commit into
masterfrom
client_ip_from_proxy

Conversation

@aagbsn

@aagbsn aagbsn commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Derive headers using features from environment variables

The rate limiter and ooniprobe (check-in geolocation, the geoip check on
submitted measurements) now take the client address from the last
X-Forwarded-For entry, which the ALB or the gateway appends, skipping
hosts listed in the new trusted_proxies setting. ooniprobe no longer
reads X-Real-IP.

Set TRUSTED_PROXIES to backend-fsn in prod (ooni/devops) before
deploying.
@aagbsn
aagbsn requested a review from hellais October 8, 2026 14:24
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (bc8e3d6) to head (4fcfe3a).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
- Coverage   98.17%   93.17%   -5.01%     
==========================================
  Files          20       91      +71     
  Lines        2084    10478    +8394     
  Branches       82      600     +518     
==========================================
+ Hits         2046     9763    +7717     
- Misses         32      585     +553     
- Partials        6      130     +124     
Flag Coverage Δ
ooniauth 100.00% <ø> (?)
oonifindings 97.32% <ø> (ø)
oonimeasurements 90.95% <100.00%> (?)
ooniprobe 91.58% <100.00%> (?)
oonirun 98.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hellais hellais changed the title Read the client address from the entry our proxy appends Adjust parsing of headers Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant