Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Rake integration #41

Closed

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Oct 21, 2016

This PR adds Opbeat reporting for Rake tasks.

Questions:

  • When should this add-on be loaded? Always? On demand by the user? If Rake is loaded?

CC: @jensnockert

@mikker
Copy link
Collaborator

mikker commented Oct 21, 2016

This is great! Thank you.

I think we ought to come up with some kind of setting to enable/disable integrations. See fx #21 .

My initial thought is to add opbeat.config.enabled_integrations = [:sidekiq, :rake, :active_record] or something like that. Then we can just add manual checks in every integration with a simple opbeat.config.enabled.include?(:sidekiq).

Sounds reasonable?

@auroranockert
Copy link
Collaborator

I think that idea sounds good @mikker.

After considering this over lunch, I think me and @olleolleolle should add some tests to check the extra data too.

@mikker
Copy link
Collaborator

mikker commented Oct 21, 2016

Good! Would you like to take a stab at implementing the integration config?

@olleolleolle
Copy link
Contributor Author

Hello, here's a status update.

The stab that I saved on my computer and then did not finish was: "Keep all of the potentially-poisonous patches to Other Software in files which are not automatically included, and load and apply them only after the configuration has told it to."

That means a bit of reorganization of the file tree, and some decision-making on what goes into the default list of enabled things.

We also tried our hand at grouping things that the user would be less interested in keeping separate. Not sure about the state of those things.

I am not currently going to finish this on my own. Is there a way to scale it back, make the change smaller, again?

@mikker
Copy link
Collaborator

mikker commented Feb 14, 2017

Sounds reasonable, @olleolleolle. Do you mean if there's a way in git to cut the drastic changes from this branch? I'd make this look like I wanted it to then fixup every commit into one using git rebase -i master (or git rebase -i origin/master if you're already on your own master).

@olleolleolle
Copy link
Contributor Author

@mikker Sorry, no, not git, just saying "I'd like to withdraw the change's scope to just be an ugly patch of Rake" that you get whatever you do.

@olleolleolle
Copy link
Contributor Author

I’ll not finish this.

@mikker
Copy link
Collaborator

mikker commented Dec 26, 2017

@olleolleolle No sweat! Good news though: All this will be in our new APM solution at @elastic! I hope you'll give it a go when I make the ✨ brand new ✨ lib public. Can't tell you when -- but you probably won't have to wait too long. See more at https://www.elastic.co/solutions/apm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants