dataprep: support air gapped env #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
reviewed
Mar 31, 2025
Contributor
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
I think there should be Dockerfile comments stating that these models and nltk are redis dependencies.
lianhao
changed the title
Collaborator
Author
Actually, these are common to most DB backends. But I've only tested it on redis. I"ve updated the description to be more precise |
chensuyue
reviewed
Apr 1, 2025
lianhao
requested review from
ftian1,
lkk12014402,
lvliang-intel,
minmin-intel and
rbrugaro
as code owners
lianhao
force-pushed
the
1488
branch
8 times, most recently
from
f5db704 to
ac7b982
Compare
eero-t
reviewed
May 19, 2025
eero-t
reviewed
May 19, 2025
- Enhance dataprep to be able to run in the air gapped environment. - Add documentionation of how to run dataprep in the air gapped environment. Related to bug opea-project#1488. Signed-off-by: Lianhao Lu <[email protected]>
lianhao
changed the title
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR introduces partial support for running the dataprep microservice in air-gapped environments by adding offline mode configurations for redis, qdrant, and milvus backends. Key changes include:
- Adding an optional "offline" parameter to start and validate service functions in the test scripts.
- Updating documentation and Docker configurations to guide air-gapped setup.
- Extending docker-compose configurations to support offline service variants.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/dataprep/test_dataprep_redis.sh | Added offline parameter handling and adjusted service startup logic. |
| tests/dataprep/test_dataprep_qdrant.sh | Introduced offline mode with corresponding start and validate logic. |
| tests/dataprep/test_dataprep_milvus.sh | Added offline mode support with a minor inconsistency in cleanup logic. |
| tests/dataprep/dataprep_utils.sh | Added a new utility function for pre-downloading dataprep models. |
| comps/dataprep/src/README_{redis,qdrant,milvus}.md | Updated documentation to include air gapped environment instructions. |
| comps/dataprep/src/Dockerfile | Created a data directory and configured environment variables for offline mode. |
| comps/dataprep/deployment/docker_compose/compose.yaml | Extended docker-compose definitions to include offline service variants. |
| comps/dataprep/README.md | Added common guide and steps for running dataprep in an air gapped env. |
eero-t
approved these changes
Jun 9, 2025
Contributor
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
Approved, looks OK to me.
chensuyue
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is partial support running dataprep in airgap env. This only has been tested on redis/milvus/qdrant backend.
Issues
Partial of #1488.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.