-
Notifications
You must be signed in to change notification settings - Fork 218
Routing service #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing service #1716
Conversation
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
…ments.txt contents Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
a23d2fb to
710df33
Compare
Signed-off-by: Madison Evans <[email protected]>
5d91ac2 to
47e15f4
Compare
…ty str Signed-off-by: Madison Evans <[email protected]>
47e15f4 to
5aab6bc
Compare
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
|
@madison-evans, |
|
https://github.com/SAPD-Intel/RouteLLM have you went through security process for this fork repo to be referenced? |
|
Hi @madison-evans Could you please check the CI failures? |
…g 'routellm-e5-base-V2' under OPEA HF group Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
for clarity, are you saying that I need to add my compose.yaml to .github/workflows/docker/compose as |
Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
…cy. Now pulls from the referenced repo and then applies the patch located at 'comps/router/src/hf_compatibility.patch' Signed-off-by: Madison Evans <[email protected]>
Signed-off-by: Madison Evans <[email protected]>
|
A bit confused why that is. The commits I've made have been contained within |
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This issue caused by deps update, and has been fixed yesterday. This |
Signed-off-by: Madison Evans <[email protected]>
|
all tests are passing now. Ready for review |
comps/router/deployment/docker_compose/configs/routellm_config.yaml
Outdated
Show resolved
Hide resolved
comps/router/deployment/docker_compose/configs/semantic_router_config.yaml
Outdated
Show resolved
Hide resolved
...router/src/integrations/controllers/semantic_router_controller/semantic_router_controller.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Haim Barad <[email protected]>
30501c0 to
96fcda3
Compare
|
Fixed as per your review comments - @ashahba |
Signed-off-by: Haim Barad <[email protected]>
ashahba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
What step (I assume last step) is needed for merge? Is "Update Branch" enough? If yes, which method? |


Description
This PR adds a Router micro-service to GenAIComps.
The router decides which downstream LLM endpoint is best suited for an incoming prompt and returns that endpoint URL.
It is stateless and supports two interchangeable controller back-ends:
gpt4_judge_battles)deployment/docker_compose/configs/routellm_config.yamldeployment/docker_compose/configs/semantic_router_config.yamlHow the configs fit together
At runtime,
docker composemounts./configs→/app/configsin the container.CONFIG_PATH=/app/configs/router.yamltells the service where to start.Deployment:
Docker Compose bundle (
deployment/docker_compose/compose.yaml+deploy_router.sh)Issues
n/a — new component
Type of change
Dependencies
New PyPI packages added to
comps/router/src/requirements.txt:routellm— an Intel fork of the RouteLLM project (https://github.com/SAPD-Intel/RouteLLM)semantic-router— embedding-based routerhuggingface-hub(pulled transitively)These depend on the existing stack (FastAPI, Pydantic, etc.).
Runtime requires
HF_TOKENandOPENAI_API_KEYsecrets.Tests
End-to-end validation script
tests/router/test_router_routellm_on_xeon.shcomps/router/src/Dockerfile)expects
"weak"route for easy math,"strong"This assumes CI pipeline already exposes
HF_TOKENandOPENAI_API_KEY, so the script is invoked automatically.