Skip to content

Conversation

@joshuayao
Copy link
Collaborator

@joshuayao joshuayao commented Jun 16, 2025

Description

TEI Reranker is a duplicate of TEI at component level. Remove it and use TEI directly. This change is part of E-RAG upstreaming tasks.

Issues

#1682

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Signed-off-by: Yi Yao <[email protected]>
@joshuayao
Copy link
Collaborator Author

Hi @yongfengdu Could you please help make changes for Infra to fit this change? Thanks!

@joshuayao joshuayao added this to the v1.4 milestone Jun 16, 2025
@joshuayao joshuayao linked an issue Jun 16, 2025 that may be closed by this pull request
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yinghu5 yinghu5 merged commit e181544 into main Jun 16, 2025
16 checks passed
@yinghu5 yinghu5 deleted the josh/removing_tei_rerank branch June 16, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Merging tei and teirerank in third_parties

5 participants