Skip to content

Conversation

@lianhao
Copy link
Collaborator

@lianhao lianhao commented Jun 17, 2025

Description

gpt-sovits: Support air gapped environment

Issues

Fixes #1482

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but why offline mode needs additional averaged_perceptron_tagger?

@lianhao
Copy link
Collaborator Author

lianhao commented Jun 24, 2025

Approved, but why offline mode needs additional averaged_perceptron_tagger?

Because that nltk data is missing from day 1 and is exposed during my offline mode testing

@eero-t
Copy link
Contributor

eero-t commented Jun 24, 2025

Approved, but why offline mode needs additional averaged_perceptron_tagger?

Because that nltk data is missing from day 1 and is exposed during my offline mode testing

So this also fixes non-offline gpt-sovits bug? If yes, please note that also in the ticket description (maybe also commit description).

@lianhao
Copy link
Collaborator Author

lianhao commented Jun 25, 2025

Approved, but why offline mode needs additional averaged_perceptron_tagger?

Because that nltk data is missing from day 1 and is exposed during my offline mode testing

So this also fixes non-offline gpt-sovits bug? If yes, please note that also in the ticket description (maybe also commit description).

This is not a bug for non-offline case. Because the missing nltk data will be automatically downloaded.

@letonghan letonghan merged commit 525504d into opea-project:main Jul 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] gpt-sovits: support air-gapped environment

5 participants