Skip to content

Conversation

@WenjiaoYue
Copy link
Collaborator

@WenjiaoYue WenjiaoYue commented Jun 30, 2025

Description

Porting Redis to OPEAStore.

Issues

#1577

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

no.

Tests

test script pass.

@pre-commit-ci pre-commit-ci bot requested a review from XinyuYe-Intel as a code owner June 30, 2025 01:38
@joshuayao joshuayao added this to the v1.4 milestone Jun 30, 2025
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/storages/redisdb.py 81.52% 34 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/storages/__init__.py 90.90% <100.00%> (+3.40%) ⬆️
comps/cores/storages/redisdb.py 81.52% <81.52%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

fix CI issue

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

add aupdate_document script

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update and specify the version number
@WenjiaoYue WenjiaoYue force-pushed the wenjiao/porting_redis_OPEAStore branch from 21e175b to 1dacd5b Compare July 2, 2025 02:30
pre-commit-ci bot and others added 6 commits July 2, 2025 02:32
Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
- Resolved lint errors from pre-commit.ci
- Added and updated test cases for RedisDBStore
- Improved coverage for aupdate_document and error cases

---------

Signed-off-by: Ubuntu <azureuser@denvr-inf.kifxisxbiwme5gt4kkwqsfdjuh.dx.internal.cloudapp.net>

Upgrade Redis version and expand test coverage

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

fix pre-commit.ci errors and increase RedisDBStore test coverage
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@letonghan letonghan merged commit 92da2d1 into main Jul 4, 2025
20 checks passed
@letonghan letonghan deleted the wenjiao/porting_redis_OPEAStore branch July 4, 2025 07:42
WenjiaoYue added a commit that referenced this pull request Jul 7, 2025
* Porting Redis to OPEAStore

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add dependencies and modify corresponding scripts

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

fix CI issue

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

add aupdate_document script

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update and specify the version number

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Upgrade Redis version and expand test coverage

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat(redis): fix pre-commit.ci issues and improve test coverage

- Resolved lint errors from pre-commit.ci
- Added and updated test cases for RedisDBStore
- Improved coverage for aupdate_document and error cases

---------

Signed-off-by: Ubuntu <azureuser@denvr-inf.kifxisxbiwme5gt4kkwqsfdjuh.dx.internal.cloudapp.net>

Upgrade Redis version and expand test coverage

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

fix pre-commit.ci errors and increase RedisDBStore test coverage

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants