Skip to content

Conversation

@MSCetin37
Copy link
Contributor

@MSCetin37 MSCetin37 commented Nov 7, 2024

Description

Extend the current Document Summarization Application by incorporating video and audio summary features. This enhancement will enable the application to summarize video and audio content in addition to text documents, thereby broadening its utility and applicability.

Issues

https://github.com/opea-project/docs/blob/main/community/rfcs/24-06-21-OPEA-001-DocSum_Video_Audio.md

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Tests

Whisper Service

Run the following command to validate the Whisper Service:

python comps/asr/whisper/dependency/check_whisper_server.py 

Expected output:

{'asr_result': 'who is pat gelsinger'}

Audio2Text Service

Run the following command to validate the Audio2Text Service:

python comps/dataprep/multimedia2text/audio2text/check_a2t_server.py

Expected output:

{'downstream_black_list': [], 'id': '21b0459477abea6d85d20f4b5ddcb714', 'query': 'who is pat gelsinger'}

Note: The id value will be different.

Video2Audio Service

Run the following command to validate the Video2Audio Service:

python comps/dataprep/multimedia2text/video2audio/check_v2a_microserver.py

Expected output:

========= Audio file saved as ======
comps/dataprep/multimedia2text/video2audio/converted_audio.wav
====================================

Multimedia2Text Service

Run the following command to validate the Multimedia2Text Service:

python comps/dataprep/multimedia2text/check_multimedia2text.py 

Expected output:

Running test: Whisper service
>>> Whisper service Test Passed ... 

Running test: Audio2Text service
>>> Audio2Text service Test Passed ... 

Running test: Video2Text service
>>> Video2Text service Test Passed ... 

Running test: Multimedia2text service
>>> Multimedia2text service test for text data type passed ... 
>>> Multimedia2text service test for audio data type passed ... 
>>> Multimedia2text service test for video data type passed ... 
cd GenAIComps/tests
bash tests/dataprep/test_dataprep_multimedia.sh

Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
@ashahba ashahba self-assigned this Nov 8, 2024
@ashahba ashahba self-requested a review November 8, 2024 00:00
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/gateway.py 40.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/proto/api_protocol.py 96.06% <100.00%> (+0.05%) ⬆️
comps/cores/proto/docarray.py 99.42% <100.00%> (+0.02%) ⬆️
comps/cores/mega/gateway.py 29.82% <40.00%> (+0.80%) ⬆️

... and 1 file with indirect coverage changes

@ashahba ashahba added this to the v1.1 milestone Nov 8, 2024
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
@ashahba ashahba mentioned this pull request Nov 11, 2024
4 tasks
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
@ashahba ashahba removed the WIP label Nov 12, 2024
ashahba and others added 5 commits November 11, 2024 22:58
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvliang-intel
Copy link
Collaborator

@MSCetin37,
please update comps/dataprep/multimedia2text/audio2text/Dockerfile to .github/workflows/docker/compose/dataprep-compose.yaml. The yaml is used for release images build.

MSCetin37 and others added 2 commits November 12, 2024 16:37
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
@ashahba
Copy link
Collaborator

ashahba commented Nov 13, 2024

@MSCetin37, please update comps/dataprep/multimedia2text/audio2text/Dockerfile to .github/workflows/docker/compose/dataprep-compose.yaml. The yaml is used for release images build.

@lvliang-intel the 3 Dockerfiles in the PR are already part of the build in that file so we are good.

@ashahba ashahba merged commit baafa40 into opea-project:main Nov 13, 2024
@lianhao
Copy link
Collaborator

lianhao commented Nov 15, 2024

The audio2text service is almost the same as the asr service except the returned data format. Why can't we combine these 2 services into one?

madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
…#865)

* v2a services

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* add a2t - llm

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update whisper serve

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* add data service

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* gateway

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* clean gateway & orchestrator

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* adding functional tests

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* updates read me file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* name changes

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update readme file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update readme file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update readme file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update readme file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update readme file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update max token option

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update the test files

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* readme updtes

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* readme updtes

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* clean code

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update dataprep-compose-cd.yaml file

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* merge and sync

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* merge and sync gateway

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* adding the copyright header

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update the end of file char

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update gateway-docsum

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test files

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* fix test files

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* merge & sync

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* Update dataprep-compose.yaml

* update test

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* update dataprep-compose

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

---------

Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com>
Co-authored-by: ZePan110 <ze.pan@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants