fix retriever and reranker to process chat completion request #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minmin-intel <[email protected]>
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
🚨 Try these New Features:
|
lkk12014402
approved these changes
Nov 19, 2024
Collaborator
|
Bug fix for DocIndexRetriever failed in v1.1 release test, https://github.com/opea-project/GenAIExamples/actions/runs/11876357287/job/33118149000 |
chensuyue
approved these changes
Nov 19, 2024
lvliang-intel
approved these changes
Nov 19, 2024
cameronmorin
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Nov 22, 2024
…roject#915) * fix retriever and reranker to process chat completion request Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cameronmorin
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Nov 28, 2024
…roject#915) * fix retriever and reranker to process chat completion request Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cameronmorin
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Dec 2, 2024
…roject#915) * fix retriever and reranker to process chat completion request Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Cameron Morin <[email protected]>
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
…roject#915) * fix retriever and reranker to process chat completion request Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing DocIndexRetriever with user input k and top_n as ChatCompletionRequest, I identified two errors:
As a result of these 2 errors, the DocIndexRetriever fails when user send ChatCompletionRequest.
This PR fixes the issues above.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
retriever and reranker unit tests, DocIndexRetriever example tests.