Add model test timeout #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun, Xuehao <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a timeout setting to model test workflows.
- Added a 10-minute timeout configuration key for the HPU workflow.
- Added a 10-minute timeout configuration key for the CPU workflow.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/model_test_hpu.yml | Added a timeout setting to the HPU workflow configuration. |
| .github/workflows/model_test_cpu.yml | Added a timeout setting to the CPU workflow configuration. |
Files not reviewed (1)
- .github/workflows/scripts/models/model_test.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/model_test_hpu.yml:35
- The 'timeout-minutes' key appears to be misaligned. It should be indented to match the other keys (e.g., 'runs-on') in the 'Evaluation-Workflow' block (likely 6 spaces) to ensure correct YAML parsing.
timeout-minutes: 10
.github/workflows/model_test_cpu.yml:35
- The 'timeout-minutes' key appears to be misaligned. It should be indented to match the other keys (e.g., 'runs-on') in the 'Evaluation-Workflow' block (likely 6 spaces) to ensure correct YAML parsing.
timeout-minutes: 10
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Sun, Xuehao <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- .github/workflows/scripts/models/collect_log.sh: Language not supported
- .github/workflows/scripts/models/generate_report.sh: Language not supported
- .github/workflows/scripts/models/model_test.sh: Language not supported
Comments suppressed due to low confidence (4)
.github/workflows/model_test_hpu.yml:35
- Please confirm that the chosen timeout of 10 minutes is sufficient for all tests. If some tests require more time, consider parameterizing this value.
+ timeout-minutes: 10
.github/workflows/model_test_hpu.yml:117
- The removal of artifact download and report generation steps may affect downstream processes that depend on these outputs. Please confirm that their removal is intentional.
- - name: Download Reference Artifact
.github/workflows/model_test_cpu.yml:35
- Verify that the 10-minute timeout meets the execution requirements for CPU-based tests. Consider whether a dynamic timeout might be needed if test duration varies.
+ timeout-minutes: 10
.github/workflows/model_test_cpu.yml:117
- The removal of artifact download and report generation steps may disrupt expected workflow outputs. Please confirm that this change aligns with the new testing approach.
- - name: Download Reference Artifact
ZePan110
approved these changes
Apr 17, 2025
chensuyue
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add model test timeout
Refine accuracy report
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
CI