Skip to content

Conversation

@chyundunovDatamonsters
Copy link
Contributor

Description

CodeGen/CodeTrans - Adding files to deploy an application in the K8S environment using Helm

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] New feature (non-breaking change which adds new functionality)

Dependencies

Tests

Chingis Yundunov and others added 17 commits February 13, 2025 10:02
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
@github-actions
Copy link

github-actions bot commented Apr 11, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

chyundunovDatamonsters and others added 9 commits April 24, 2025 09:51
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…nto feature/CodeGen_CodeTrans_k8s

# Conflicts:
#	CodeGen/kubernetes/helm/rocm-tgi-values.yaml
#	CodeTrans/kubernetes/helm/rocm-tgi-values.yaml
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@yinghu5 yinghu5 requested review from Copilot and yongfengdu April 25, 2025 01:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new Helm chart files and documentation to deploy an application in a Kubernetes environment using Helm with AMD ROCm support. Key changes include:

  • Adding separate values YAML files for ROCm deployments with vLLM and TGI configurations.
  • Updating README documentation to provide detailed deployment instructions for both CodeTrans and CodeGen.
  • Including system variable setup instructions and command examples for both binary repository and Git repository based deployments.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CodeTrans/kubernetes/helm/rocm-values.yaml New Helm values file for configuring ROCm vLLM deployment.
CodeTrans/kubernetes/helm/rocm-tgi-values.yaml New Helm values file for configuring ROCm TGI deployment.
CodeTrans/kubernetes/helm/README.md Updated deployment instructions for CodeTrans.
CodeGen/kubernetes/helm/rocm-values.yaml New Helm values file for configuring ROCm vLLM deployment.
CodeGen/kubernetes/helm/rocm-tgi-values.yaml New Helm values file for configuring ROCm TGI deployment.
CodeGen/kubernetes/helm/README.md Updated deployment instructions for CodeGen with a minor typo.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why not running as non-root for greater security.
LGTM

### Creating working dirs

```bash
mkdir ~/codetrans-k8s-install && cd ~/codetrans-k8s-install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you created the directory, cd to it. All the other paths then get shorter, do not need to reference ~/codetrans-k8s-install everywhere

memory: 16Gi
securityContext:
readOnlyRootFilesystem: false
runAsNonRoot: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a PR to GenAIInfra?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here it's ok to keep run with root? Why chatqna is special? https://github.com/opea-project/GenAIInfra/pull/949/files/180f16fb65570968a44663d0490c42ed539862b0#diff-f93551169c7cda08f51cb91abe0a36eb96356b53ace54c5fd940d24d5d4264acR29

Changes to the launch from an unprivileged user will be made after this PR is completed - opea-project/GenAIComps#1638

chyundunovDatamonsters and others added 4 commits May 27, 2025 12:11
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm

Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@CICD-at-OPEA
Copy link
Collaborator

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@CICD-at-OPEA
Copy link
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

letonghan pushed a commit that referenced this pull request Sep 17, 2025
* add native pii detection guardrail

Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix port name env var. and typo

Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix license dates

Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants