-
Notifications
You must be signed in to change notification settings - Fork 339
CodeGen/CodeTrans - Adding files to deploy an application in the K8S environment using Helm #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
…environment using Helm Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
…into feature/CodeGen_CodeTrans_k8s
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…nto feature/CodeGen_CodeTrans_k8s
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
for more information, see https://pre-commit.ci
…into feature/CodeGen_CodeTrans_k8s
…nto feature/CodeGen_CodeTrans_k8s
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
for more information, see https://pre-commit.ci
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…nto feature/CodeGen_CodeTrans_k8s # Conflicts: # CodeGen/kubernetes/helm/rocm-tgi-values.yaml # CodeTrans/kubernetes/helm/rocm-tgi-values.yaml
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
for more information, see https://pre-commit.ci
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new Helm chart files and documentation to deploy an application in a Kubernetes environment using Helm with AMD ROCm support. Key changes include:
- Adding separate values YAML files for ROCm deployments with vLLM and TGI configurations.
- Updating README documentation to provide detailed deployment instructions for both CodeTrans and CodeGen.
- Including system variable setup instructions and command examples for both binary repository and Git repository based deployments.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CodeTrans/kubernetes/helm/rocm-values.yaml | New Helm values file for configuring ROCm vLLM deployment. |
| CodeTrans/kubernetes/helm/rocm-tgi-values.yaml | New Helm values file for configuring ROCm TGI deployment. |
| CodeTrans/kubernetes/helm/README.md | Updated deployment instructions for CodeTrans. |
| CodeGen/kubernetes/helm/rocm-values.yaml | New Helm values file for configuring ROCm vLLM deployment. |
| CodeGen/kubernetes/helm/rocm-tgi-values.yaml | New Helm values file for configuring ROCm TGI deployment. |
| CodeGen/kubernetes/helm/README.md | Updated deployment instructions for CodeGen with a minor typo. |
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
mkbhanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why not running as non-root for greater security.
LGTM
| ### Creating working dirs | ||
|
|
||
| ```bash | ||
| mkdir ~/codetrans-k8s-install && cd ~/codetrans-k8s-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you created the directory, cd to it. All the other paths then get shorter, do not need to reference ~/codetrans-k8s-install everywhere
| memory: 16Gi | ||
| securityContext: | ||
| readOnlyRootFilesystem: false | ||
| runAsNonRoot: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here it's ok to keep run with root? Why chatqna is special? https://github.com/opea-project/GenAIInfra/pull/949/files/180f16fb65570968a44663d0490c42ed539862b0#diff-f93551169c7cda08f51cb91abe0a36eb96356b53ace54c5fd940d24d5d4264acR29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a PR to GenAIInfra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/codetrans/rocm-values.yaml The CodeGen/CodeTrans PRs for GenAIInfra had been merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here it's ok to keep run with root? Why chatqna is special? https://github.com/opea-project/GenAIInfra/pull/949/files/180f16fb65570968a44663d0490c42ed539862b0#diff-f93551169c7cda08f51cb91abe0a36eb96356b53ace54c5fd940d24d5d4264acR29
Changes to the launch from an unprivileged user will be made after this PR is completed - opea-project/GenAIComps#1638
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
for more information, see https://pre-commit.ci
…environment using Helm Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
…nto feature/CodeGen_CodeTrans_k8s
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
* add native pii detection guardrail Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix port name env var. and typo Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix license dates Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: daniel-de-leon-user293 <daniel.de.leon@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com>
Description
CodeGen/CodeTrans - Adding files to deploy an application in the K8S environment using Helm
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Tests