Fix ChatQnA README regression #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
requested review from
Copilot
and removed request for
lianhao and
yongfengdu
There was a problem hiding this comment.
Pull Request Overview
Clarify that some subservices in the ChatQnA Helm chart are conditionally required and update the gaudi values file reference.
- Update README introduction to reflect conditional subservices
- Fix the filename for the gaudi install values file in a commented command
Comments suppressed due to low confidence (1)
helm-charts/chatqna/README.md:30
- Verify that
chatqna/gaudi-values.yamlexists in the repository and matches the intended filename, so the example install command remains accurate.
#helm install chatqna chatqna --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set global.modelUseHostPath=${MODELDIR} --set vllm.LLM_MODEL_ID=${MODELNAME} -f chatqna/gaudi-values.yaml
Introduced also by opea-project#949, and update first README clause to indicate that some of the subservices are conditional. Signed-off-by: Eero Tamminen <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a README regression by clarifying that some subservice dependencies are conditional and updating an installation command.
- Updated the introductory clause to better describe dependency conditions.
- Revised the Helm install comment to reference the correct values file.
lianhao
approved these changes
May 22, 2025
poussa
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update first README clause to indicate that some of the subservices are conditional, and fix another ChatQnA README regression introduced by #949.
Issues
n/a.Type of change
Dependencies
n/a.Tests
CI.