Add gateway mode support and custom nginx configuration to OPEA nginx… #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nothing wrong with the PR but I would like us to explore a different approach. That is, to use K8s Gateway APIs. With Gateway APIs we can define the routing. In addition, we can select the backend from the growing number servers that supports Gateway APIs including Nginx, Envoy, APISIX and many others. |
lianhao
requested changes
Jun 4, 2025
Collaborator
|
@poussa agreed we can explore the gateway API approach. But in the meanwhile, I think we should not block this PR since @devpramod is contributing their existing deployment patches back to community. |
louie-tsai
reviewed
Jun 10, 2025
poussa
approved these changes
Jun 13, 2025
poussa
reviewed
Jun 16, 2025
… chart Signed-off-by: devpramod <[email protected]>
…, updating example configurations, and streamlining values and templates to better support gateway deployments while removing unnecessary service and UI settings. Signed-off-by: devpramod <[email protected]>
devpramod
force-pushed
the
feature/custom-nginx-template
branch
from
ff96ebb to
ade7534
Compare
lianhao
requested changes
Jun 18, 2025
lianhao
requested changes
Jun 18, 2025
…aml as it is an example values file Signed-off-by: devpramod <[email protected]>
devpramod
force-pushed
the
feature/custom-nginx-template
branch
from
882598c to
110c9d9
Compare
lianhao
requested changes
Jun 19, 2025
Collaborator
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
Once we make the doc CI task happy, this is ready to go
Signed-off-by: devpramod <[email protected]>
devpramod
force-pushed
the
feature/custom-nginx-template
branch
from
22f7fe2 to
fa164bf
Compare
for more information, see https://pre-commit.ci
lianhao
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx Helm Chart
Description
This PR enhances the nginx helm chart to support gateway mode functionality while maintaining backward
compatibility. The changes enable nginx to act as a central API gateway/router for multiple OPEA services,
providing unified access through a single endpoint.
Key changes:
nginxConfigparametercustomCommandparameterIssues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.
gateway-values.yaml