Skip to content

Conversation

@lianhao
Copy link
Collaborator

@lianhao lianhao commented Jun 12, 2025

Description

whisper: support air gapped environment.

Issues

Fix opea-project/GenAIComps#1487

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao requested a review from yongfengdu as a code owner June 12, 2025 02:38
Copy link
Collaborator

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (below are couple of suggestions you're free to ignore).

@lianhao lianhao force-pushed the airgap-whisper branch 3 times, most recently from 11433d3 to f815a4c Compare June 17, 2025 06:38
@lianhao lianhao added this to the v1.4 milestone Jul 1, 2025
@lianhao lianhao force-pushed the airgap-whisper branch 3 times, most recently from 13b0189 to 6dd5aa4 Compare July 4, 2025 07:00
@lianhao lianhao requested a review from poussa July 4, 2025 07:12
Copy link
Member

@poussa poussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits.

@poussa poussa merged commit c483654 into opea-project:main Jul 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] whisper: support air-gapped environment

3 participants