Skip to content

Conversation

@lianhao
Copy link
Collaborator

@lianhao lianhao commented Jun 16, 2025

Description

speecht5: Support air gapped environment

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao requested a review from yongfengdu as a code owner June 16, 2025 08:12
@lianhao
Copy link
Collaborator Author

lianhao commented Jun 16, 2025

This PR depends on opea-project/GenAIComps#1801 to land in first

Copy link
Collaborator

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with README suggestion.

(I should have suggested these also for earlier offline PRs.)

@lianhao lianhao added this to the v1.4 milestone Jul 1, 2025
@poussa poussa self-requested a review July 3, 2025 13:50
@eero-t
Copy link
Collaborator

eero-t commented Jul 3, 2025

For some reason the merged suggestions lack sign-off (from you?), and therefore DCO test fails.

Do you have access rights to correct that, or does @lianhao need to do that?

@lianhao lianhao force-pushed the airgap-speecht5 branch from 6613b59 to fcdd3c9 Compare July 4, 2025 01:57
@poussa poussa merged commit 49c5c32 into opea-project:main Jul 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants