tei: upgrade to version cpu-1.7 #1134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
requested changes
Jun 27, 2025
Collaborator
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
TEI image is the only thing with cpu-1.5 tag, so it's easy to find instances where it's used. TEI values file is not the only place:
$ git grep -l cpu-1.5
helm-charts/chatqna/faqgen-rocm-tgi-values.yaml
helm-charts/chatqna/faqgen-rocm-values.yaml
helm-charts/chatqna/rocm-tgi-values.yaml
helm-charts/chatqna/rocm-values.yaml
helm-charts/common/tei/README.md
helm-charts/common/tei/values.yaml
helm-charts/common/teirerank/README.md
helm-charts/common/teirerank/values.yaml
microservices-connector/config/manifests/data-prep_milvus.yaml
microservices-connector/config/manifests/retriever-usvc_milvus.yaml
microservices-connector/config/manifests/tei.yaml
microservices-connector/config/manifests/tei_gaudi.yaml
microservices-connector/config/manifests/teirerank.yaml
microservices-connector/config/manifests/teirerank_gaudi.yaml
microservices-connector/config/samples/ChatQnA/use_cases.md
Collaborator
|
Why ChatQnA ROCM value files (#949) added duplicated TEI default CPU values? I think |
Upgrade tei/teirerank default version to cpu-1.7. Remove duplicated teirerank settings for chatqna rocm environment. Signed-off-by: Lianhao Lu <[email protected]>
Collaborator
Author
Done |
Collaborator
Author
Also updated teirerank. GMC will not be covered in this PR. |
Collaborator
Author
|
weird github action error. Will close this PR and recreate new one #1135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tei: upgrade to version cpu-1.7
Issues
Fixes #1133.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.