Skip to content

Extend CI scripts to test for external LLM endpoints #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkbhanda merged 2 commits into from
Jul 3, 2025
Merged

Extend CI scripts to test for external LLM endpoints #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e158669
add changes to CI to enable external llm endpoint testing
devpramod Jul 1, 2025
2c00236
fix trailing whitespace
devpramod Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/_helm-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ jobs:
HFTOKEN: ${{ secrets.HF_TOKEN }}
FINNHUB_API_KEY: ${{ secrets.FINNHUB_API_KEY }}
FINANCIAL_DATASETS_API_KEY: ${{ secrets.FINANCIAL_DATASETS_API_KEY }}
# External LLM configuration for external-llm-values.yaml testing
LLM_SERVER_HOST_IP: ${{ secrets.LLM_SERVER_HOST_IP }}
LLM_SERVICE_HOST_IP: ${{ secrets.LLM_SERVER_HOST_IP }}
LLM_MODEL: ${{ secrets.LLM_MODEL }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
LLM_SERVER_PORT: ${{ secrets.LLM_SERVER_PORT }}
LLM_SERVICE_PORT: ${{ secrets.LLM_SERVER_PORT }}
run: |
set -x
USER_ID=$(whoami)
Expand All @@ -127,6 +134,40 @@ jobs:
ROLLOUT_TIMEOUT_SECONDS=900s
fi
done

# Prepare external LLM arguments for external-llm-values.yaml files
external_llm_args=""
if [[ "${value_file}" == *"external-llm"* ]]; then
# Chart-specific mapping for environment variables (use LLM_SERVER_HOST_IP for all)
if [[ "${{ env.CHART_NAME }}" == "chatqna" ]]; then
if [[ -n "${{ env.LLM_SERVER_HOST_IP }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_SERVER_HOST_IP=${{ env.LLM_SERVER_HOST_IP }}"
fi
if [[ -n "${{ env.LLM_SERVER_PORT }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_SERVER_PORT=${{ env.LLM_SERVER_PORT }}"
fi
else
# DocSum/CodeGen use LLM_SERVICE_HOST_IP but we map from LLM_SERVER_HOST_IP
if [[ -n "${{ env.LLM_SERVER_HOST_IP }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_SERVICE_HOST_IP=${{ env.LLM_SERVER_HOST_IP }}"
fi
if [[ -n "${{ env.LLM_SERVER_PORT }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_SERVICE_PORT=${{ env.LLM_SERVER_PORT }}"
fi
fi
if [[ -n "${{ env.LLM_MODEL }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_MODEL=${{ env.LLM_MODEL }}"
# CodeGen also needs LLM_MODEL_ID
if [[ "${{ env.CHART_NAME }}" == "codegen" ]]; then
external_llm_args="$external_llm_args --set externalLLM.LLM_MODEL_ID=${{ env.LLM_MODEL }}"
fi
fi
if [[ -n "${{ env.OPENAI_API_KEY }}" ]]; then
external_llm_args="$external_llm_args --set externalLLM.OPENAI_API_KEY=${{ env.OPENAI_API_KEY }}"
fi
echo "External LLM configuration detected for ${{ env.CHART_NAME }}, adding arguments: $external_llm_args"
fi

if ! helm install --create-namespace --namespace $NAMESPACE --wait \
--timeout "$ROLLOUT_TIMEOUT_SECONDS" \
--set GOOGLE_API_KEY=${{ env.GOOGLE_API_KEY }} \
Expand All @@ -139,6 +180,7 @@ jobs:
--set research-agent.FINANCIAL_DATASETS_API_KEY=${{ env.FINANCIAL_DATASETS_API_KEY }} \
--set global.HUGGINGFACEHUB_API_TOKEN=${{ env.HFTOKEN }} \
--set global.modelUseHostPath=${CHART_MOUNT} \
${external_llm_args} \
--values ${{ env.CHART_FOLDER }}/${value_file} \
$RELEASE_NAME ${{ env.CHART_FOLDER }} ; then
echo "Failed to install chart ${{ inputs.workload }}"
Expand Down