-
Notifications
You must be signed in to change notification settings - Fork 98
Enable docsum to connect with external llm endpoints via helm #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
db09e2a
Enable docsum to connect with external llm endpoints via helm
devpramod bee11e0
modify values yaml name
250c574
addressed PR comment
19e1030
change host and port names for external llm env variables
devpramod d60651f
enable llm-uservice to point to external llm endpoints
devpramod 20db664
add env variable for api key in llm-uservice configmap
devpramod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,12 @@ helm install docsum docsum --set global.HF_TOKEN=${HFTOKEN} --set global.modelUs | |
| # helm install docsum docsum --set global.HF_TOKEN=${HFTOKEN} --values docsum/rocm-values.yaml | ||
| # To use AMD ROCm device with TGI | ||
| # helm install docsum docsum --set global.HF_TOKEN=${HFTOKEN} --values docsum/rocm-tgi-values.yaml | ||
|
|
||
| # To use with external OpenAI-compatible LLM endpoints (OpenAI, vLLM, TGI, etc.) | ||
| # This configures the llm-uservice to connect to external LLM providers while maintaining DocSum compatibility | ||
| # For OpenAI: | ||
| # helm install docsum docsum --values docsum/variant_external-llm-values.yaml --set llm-uservice.OPENAI_API_KEY="your-api-key" --set llm-uservice.LLM_ENDPOINT="https://api.openai.com" --set llm-uservice.LLM_MODEL_ID="gpt-4-turbo" | ||
| # For vLLM/TGI or other OpenAI-compatible endpoints: | ||
| # helm install docsum docsum --values docsum/variant_external-llm-values.yaml --set llm-uservice.LLM_ENDPOINT="http://your-server-url" --set llm-uservice.LLM_MODEL_ID="your-model" | ||
|
Comment on lines
+29
to
+34
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you do separate PR adding similar stuff for FaqGen in ChatQnA Helm chart? (Separate variant file, README instructions etc.) |
||
| ``` | ||
|
|
||
| ## Verify | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,17 @@ | ||||||
| # Copyright (C) 2024 Intel Corporation | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| # SPDX-License-Identifier: Apache-2.0 | ||||||
|
|
||||||
| # External LLM configuration - configures llm-uservice to use external LLM providers | ||||||
| # This keeps the llm-uservice wrapper (required for /v1/docsum endpoint) but connects it to external LLMs | ||||||
| llm-uservice: | ||||||
| enabled: true # Keep the wrapper service for DocSum compatibility | ||||||
| DOCSUM_BACKEND: "vLLM" # Use vLLM backend for OpenAI-compatible APIs | ||||||
| LLM_ENDPOINT: "https://api.openai.com" # External LLM API endpoint (omit /v1 suffix) | ||||||
| OPENAI_API_KEY: "${OPENAI_API_KEY}" # API key for authentication | ||||||
| LLM_MODEL_ID: "gpt-4-turbo" # Model to use | ||||||
|
|
||||||
| # Disable local inference services since we're using external LLMs | ||||||
| vllm: | ||||||
| enabled: false | ||||||
| tgi: | ||||||
| enabled: false | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.