Skip to content

Conversation

@lianhao
Copy link
Collaborator

@lianhao lianhao commented Jul 4, 2025

Description

Use global.HF_TOKEN to deprecate global.HUGGINGFACEHUB_API_TOKEN.

Issues

Fixes #1108.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao requested a review from yongfengdu as a code owner July 4, 2025 06:26
@lianhao lianhao requested review from eero-t and poussa July 4, 2025 06:30
Use global.HF_TOKEN to deprecate global.HUGGINGFACEHUB_API_TOKEN

Signed-off-by: Lianhao Lu <[email protected]>
@poussa poussa merged commit 107bbf4 into opea-project:main Jul 4, 2025
18 of 102 checks passed
@eero-t
Copy link
Collaborator

eero-t commented Jul 4, 2025

Thanks for these PRs, it makes typing the commands much nicer!

@lianhao There are still few configMaps that set also the old HUGGINGFACEHUB_API_TOKEN value, haven't those services been migrated yet in GenAIComps?

GenAIInfra/helm-charts$ git grep -l HUGGINGFACEHUB_API_TOKEN: 
common/agent/templates/configmap.yaml
common/data-prep/templates/configmap.yaml
common/guardrails-usvc/templates/configmap.yaml
common/lvm-serve/templates/configmap.yaml
common/retriever-usvc/templates/configmap.yaml

GMC microservices YAMLs are also completely out of date. @poussa any idea what's going to be done with those?

@lianhao
Copy link
Collaborator Author

lianhao commented Jul 4, 2025

Thanks for these PRs, it makes typing the commands much nicer!

@lianhao There are still few configMaps that set also the old HUGGINGFACEHUB_API_TOKEN value, haven't those services been migrated yet in GenAIComps?

GenAIInfra/helm-charts$ git grep -l HUGGINGFACEHUB_API_TOKEN: 
common/agent/templates/configmap.yaml
common/data-prep/templates/configmap.yaml
common/guardrails-usvc/templates/configmap.yaml
common/lvm-serve/templates/configmap.yaml
common/retriever-usvc/templates/configmap.yaml

GMC microservices YAMLs are also completely out of date. @poussa any idea what's going to be done with those?

The remaining HUGGINGFACEHUB_API_TOKEN in the configmap is from previous GenAIComps due to the dependent HF python libraries' ability to support new HF_TOKEN. I'll try to verify and remove them one by one in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] rename HUGGINGFACEHUB_API_TOKEN to HF_TOKEN

4 participants