Skip to content

Conversation

@eero-t
Copy link
Collaborator

@eero-t eero-t commented Jul 4, 2025

Description

Fix #993 values file names to match README.

Issues

n/a.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a.

Tests

CI.

@lianhao
Copy link
Collaborator

lianhao commented Jul 4, 2025

I think we need to fix README, the variant_ prefix here is meant to temporarily skip CI

@eero-t eero-t changed the title Fix values file names to match README Fix READMEs to match (external LLM) values file names Jul 4, 2025
@eero-t
Copy link
Collaborator Author

eero-t commented Jul 4, 2025

I think we need to fix README, the variant_ prefix here is meant to temporarily skip CI

Thanks, done.

@eero-t eero-t requested a review from poussa July 4, 2025 10:46
@eero-t
Copy link
Collaborator Author

eero-t commented Jul 4, 2025

I think we need to fix README, the variant_ prefix here is meant to temporarily skip CI

Btw. was the merged #1140 supposed to fix CI for external endpoints?

@lianhao
Copy link
Collaborator

lianhao commented Jul 7, 2025

I think we need to fix README, the variant_ prefix here is meant to temporarily skip CI

Btw. was the merged #1140 supposed to fix CI for external endpoints?

Nope. We also need to Suyue's help to setup the corresponding secrets to be used by #1140

@lianhao lianhao merged commit 0cb9564 into opea-project:main Jul 7, 2025
7 checks passed
@eero-t eero-t deleted the values-files branch August 11, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants