Grafana script + README improvements #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
There were some other potential issues Sakari noticed, which might need additional fix or README explanation, so I set this as draft until we've finished investigating them. |
Collaborator
Author
@poussa Did not answer on whether something was wrong with the earlier dashboards, but this fixes the other issues he commented => dropped "draft" status + rebased to |
eero-t
force-pushed
the
grafana-fixes
branch
3 times, most recently
from
ab1156c to
064ec8a
Compare
* Fix shellcheck warnings * Improve dashboard JSON validity checks - Grafana will generate 'uid' on configMap load if it is missing * Make sure dashboard configMap name matches k8s rules * Restart Grafana to make sure it picks up the configMap updates Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
eero-t
force-pushed
the
grafana-fixes
branch
from
064ec8a to
c2c36d1
Compare
poussa
approved these changes
Nov 26, 2024
lianhao
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes based on feedback from testing by @poussa.
Script updates:
README updates:
configMapusage for dashboards hasIssues
n/a.Type of change
Dependencies
n/a.Tests
Manual testing