helm-chart: update nginx config and minor changes #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongfengdu
approved these changes
Nov 22, 2024
lianhao
reviewed
Nov 22, 2024
Collaborator
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
I think it's better to align with opea/nginx to add the following lines in nginx config too:
Ruoyu-y
force-pushed
the
update_nginx
branch
from
a94b807 to
910ca7c
Compare
* change the nginx configuration Signed-off-by: Ruoyu Ying <[email protected]>
Ruoyu-y
force-pushed
the
update_nginx
branch
from
910ca7c to
dc1ff69
Compare
lianhao
approved these changes
Nov 22, 2024
chensuyue
pushed a commit
that referenced
this pull request
Nov 22, 2024
* change the nginx configuration Signed-off-by: Ruoyu Ying <[email protected]> (cherry picked from commit 9714cde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
#589
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n\aTests
n\a