-
Notifications
You must be signed in to change notification settings - Fork 26
agentqna patches #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agentqna patches #53
Conversation
Signed-off-by: cheehook <[email protected]>
Signed-off-by: wwanrif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the application manifests for tool extraction by changing the repository URL and adjusting the tar extraction components and refactors conversation streaming logic to better handle agent messages with think blocks.
- Changed TOOLS_GIT_URL from one project to another and updated tar extraction parameters in multiple YAML manifest files.
- Refactored ConversationSlice.ts to remove legacy code and add buffers and flags for handling blocks in streaming responses.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| studio-backend/tests/exporter-groundtruth/gt_app-manifest.yaml | Updated repository URL and increased tar --strip-components from 4 to 5. |
| studio-backend/tests/exporter-groundtruth/gt_app-manifest-with-nginx.yaml | Same updates for URL and tar extraction as in gt_app-manifest.yaml. |
| studio-backend/app/templates/microsvc-manifests/supervisor-agent.yaml, sql-agent.yaml, rag-agent.yaml | Updated repository URL and tar extraction parameters across multiple agent manifest files. |
| app-frontend/react/src/redux/Conversation/ConversationSlice.ts | Refactored message accumulation, especially around handling blocks and final message dispatch. |
Comments suppressed due to low confidence (1)
studio-backend/tests/exporter-groundtruth/gt_app-manifest.yaml:807
- The change from --strip-components=4 to --strip-components=5 may lead to an off-by-one error if the directory structure has not been updated accordingly. Please confirm that this modification accurately reflects the intended file layout.
curl "${DOWNLOAD_URL}" | tar -xz --strip-components=5 -C /home/user/tools/ "${REPO}-${BRANCH}/${TOOLS_DIR}"
Signed-off-by: wwanrif <[email protected]>
Signed-off-by: cheehook <[email protected]>
fix text area not grey out during agent is generating response Signed-off-by: cheehook <[email protected]>
Signed-off-by: wwanrif <[email protected]>
|
lgtm |
* patching to latest agent output format for openwebui compatible Signed-off-by: cheehook <[email protected]> * change source of agent-tools Signed-off-by: wwanrif <[email protected]> * removed agentqna tools from app-backend templates Signed-off-by: wwanrif <[email protected]> * remove tool mount for sql agent as it cause confusion to react agent Signed-off-by: cheehook <[email protected]> * change token counting for latest agent changes fix text area not grey out during agent is generating response Signed-off-by: cheehook <[email protected]> * update for sql agent Signed-off-by: wwanrif <[email protected]> --------- Signed-off-by: cheehook <[email protected]> Signed-off-by: wwanrif <[email protected]> Co-authored-by: cheehook <[email protected]>
No description provided.