Skip to content

Conversation

@wanhakim
Copy link
Collaborator

No description provided.

@wanhakim wanhakim requested review from OngSoonEe and Copilot April 18, 2025 00:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the application manifests for tool extraction by changing the repository URL and adjusting the tar extraction components and refactors conversation streaming logic to better handle agent messages with think blocks.

  • Changed TOOLS_GIT_URL from one project to another and updated tar extraction parameters in multiple YAML manifest files.
  • Refactored ConversationSlice.ts to remove legacy code and add buffers and flags for handling blocks in streaming responses.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

File Description
studio-backend/tests/exporter-groundtruth/gt_app-manifest.yaml Updated repository URL and increased tar --strip-components from 4 to 5.
studio-backend/tests/exporter-groundtruth/gt_app-manifest-with-nginx.yaml Same updates for URL and tar extraction as in gt_app-manifest.yaml.
studio-backend/app/templates/microsvc-manifests/supervisor-agent.yaml, sql-agent.yaml, rag-agent.yaml Updated repository URL and tar extraction parameters across multiple agent manifest files.
app-frontend/react/src/redux/Conversation/ConversationSlice.ts Refactored message accumulation, especially around handling blocks and final message dispatch.
Comments suppressed due to low confidence (1)

studio-backend/tests/exporter-groundtruth/gt_app-manifest.yaml:807

  • The change from --strip-components=4 to --strip-components=5 may lead to an off-by-one error if the directory structure has not been updated accordingly. Please confirm that this modification accurately reflects the intended file layout.
curl "${DOWNLOAD_URL}" | tar -xz --strip-components=5 -C /home/user/tools/ "${REPO}-${BRANCH}/${TOOLS_DIR}"

wanhakim and others added 4 commits April 18, 2025 00:41
@siawchen siawchen self-requested a review April 21, 2025 17:26
@siawchen
Copy link
Collaborator

lgtm

@siawchen siawchen removed the request for review from OngSoonEe April 21, 2025 17:28
@siawchen siawchen merged commit 8a7fc86 into opea-project:main Apr 21, 2025
5 checks passed
@siawchen siawchen added this to the v1.3 milestone Apr 21, 2025
wanhakim added a commit that referenced this pull request Apr 21, 2025
* patching to latest agent output format for openwebui compatible

Signed-off-by: cheehook <[email protected]>

* change source of agent-tools

Signed-off-by: wwanrif <[email protected]>

* removed agentqna tools from app-backend templates

Signed-off-by: wwanrif <[email protected]>

* remove tool mount for sql agent as it cause confusion to react agent

Signed-off-by: cheehook <[email protected]>

* change token counting for latest agent changes
fix text area not grey out during agent is generating response

Signed-off-by: cheehook <[email protected]>

* update for sql agent

Signed-off-by: wwanrif <[email protected]>

---------

Signed-off-by: cheehook <[email protected]>
Signed-off-by: wwanrif <[email protected]>
Co-authored-by: cheehook <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants