-
Notifications
You must be signed in to change notification settings - Fork 25
Bug fixes and new playwright tests #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
* update sandbox run error handling and fixes for docsum and codegen workflows (opea-project#69) * update setup playbooks Signed-off-by: wwanarif <[email protected]> * debuglogs to display the connections between pods Signed-off-by: wwanarif <[email protected]> * fix chat history bug and duplicate workflow bug Signed-off-by: wwanarif <[email protected]> * fix genai-studio ansible to include create-ssh-secrets playbook Signed-off-by: wwanarif <[email protected]> * update to sandbox run error handling Signed-off-by: wwanarif <[email protected]> * fix for docum and codegen workflows Signed-off-by: wwanarif <[email protected]> --------- Signed-off-by: wwanarif <[email protected]> * fix for agent think card 1. filter tool call in final output 2. if streaming response in progress, keep showing response is generating message 3. if final output no answer, print iteration limit reached without final answer Signed-off-by: cheehook <[email protected]> * Revert "Merge branch 'main' into agentqna_ui_fix" This reverts commit fe0d83c, reversing changes made to 27f8d63. * Revert "Revert "Merge branch 'main' into agentqna_ui_fix"" This reverts commit a0e1cd5. * fix wrongly merge conflict --------- Signed-off-by: wwanarif <[email protected]> Signed-off-by: cheehook <[email protected]> Co-authored-by: wanhakim <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements comprehensive bug fixes and adds new Playwright tests for document summarization and code generation functionalities. The changes include improvements to UI configuration management, deployment workflow enhancements, template updates for better compatibility, and new test coverage for key features.
Key Changes:
- Added new Playwright test files for document summarization and code generation workflows
- Enhanced deployment functionality with automatic namespace deletion and improved monitoring
- Updated UI to support dynamic default types and better file upload handling for summarization
- Migrated environment variable names from HUGGINGFACEHUB_API_TOKEN to HF_TOKEN for consistency
Reviewed Changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/playwright/studio-e2e/004_test_sandbox_codegen.spec.ts | New Playwright test for code generation sandbox functionality |
| tests/playwright/studio-e2e/003_test_sandbox_docsum.spec.ts | New Playwright test for document summarization sandbox functionality |
| tests/test-files/Little Red Ridding Hood.txt | Test data file containing Little Red Riding Hood story for testing |
| studio-frontend/packages/ui/src/ui-component/table/FlowListTable.jsx | Enhanced deployment WebSocket management and namespace deletion handling |
| studio-frontend/packages/ui/src/ui-component/dialog/OneClickDeploymentDialog.jsx | Improved deployment dialog with persistent WebSocket connections |
| studio-backend/app/services/namespace_service.py | Enhanced namespace management with automatic deletion and better pod monitoring |
| app-frontend/react/src/redux/Conversation/ConversationSlice.ts | Added dynamic default UI type detection and improved event stream handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
studio-frontend/packages/ui/src/ui-component/dialog/OneClickDeploymentDialog.jsx
Show resolved
Hide resolved
Signed-off-by: wwanarif <[email protected]>
siawchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.