-
Notifications
You must be signed in to change notification settings - Fork 25
Finetuning + fixes #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
… create modal Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
…sions Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a comprehensive fine-tuning feature to the GenAI Studio platform along with several infrastructure improvements and UI refinements. The changes enable users to create, monitor, and manage fine-tuning jobs for language models through a new dedicated interface.
Key Changes:
- Added complete fine-tuning functionality with job creation, monitoring, and output download capabilities
- Implemented WebSocket-based real-time job status updates and asynchronous download preparation
- Enhanced UI with collapsible sidebar navigation and consistent styling across views
- Improved deployment infrastructure with proxy support and enhanced service discovery
Reviewed changes
Copilot reviewed 81 out of 84 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| studio-frontend/packages/ui/vite.config.js | Added WebSocket proxy configuration for socket.io connections |
| studio-frontend/packages/ui/src/views/finetuning/index.jsx | New fine-tuning jobs view with real-time monitoring |
| studio-frontend/packages/ui/src/views/finetuning/FinetuningJobsTable.jsx | Jobs table with status tracking, logs viewer, and download functionality |
| studio-frontend/packages/ui/src/views/finetuning/FinetuningJobModal.jsx | Modal dialog for creating new fine-tuning jobs with extensive configuration options |
| studio-frontend/packages/ui/src/api/finetuning.js | API client for fine-tuning operations with WebSocket support |
| studio-frontend/packages/ui/src/layout/MainLayout/Sidebar/index.jsx | Collapsible sidebar with expanded/collapsed states |
| studio-frontend/packages/ui/src/menu-items/dashboard.js | Updated menu to include fine-tuning option |
| studio-frontend/packages/server/src/services/finetuning/index.ts | Backend service for fine-tuning job management and file operations |
| studio-frontend/packages/server/src/ws/finetuningStatus.ts | WebSocket handler for real-time job status updates |
| studio-frontend/packages/server/src/ws/finetuningDownload.ts | WebSocket handler for asynchronous download preparation |
| studio-backend/app/utils/placeholders_utils.py | Enhanced NO_PROXY handling for service endpoints |
| studio-backend/app/services/exporter_service.py | Improved service endpoint configuration for app-backend |
| setup-scripts/setup-genai-studio/cleanup-genai-studio.sh | Comprehensive cleanup script for GenAI Studio resources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
Signed-off-by: wwanarif <[email protected]>
siawchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.