-
Notifications
You must be signed in to change notification settings - Fork 88
Update and simplify CodeGen tutorials #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: alexsin368 <[email protected]>
…ices commands Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies and updates the CodeGen tutorial deployment guides by removing redundant steps and improving the clarity of instructions. Key changes include updated port forwarding examples, revised deployment commands for both vLLM and TGI services, and improved language and grammar throughout the tutorials.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tutorial/CodeGen/deploy/xeon.md | Revised instructions, fixed grammar issues, and updated commands for deploying on Xeon. |
| tutorial/CodeGen/deploy/gaudi.md | Updated deployment steps and commands for Gaudi deployments, with updated model details. |
Files not reviewed (1)
- tutorial/CodeGen/CodeGen_Guide.rst: Language not supported
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
mkbhanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do a quick check for consistency/recommendation on model (7B versus 32B) for Xeon versus Gaudi. Also add a recommendation on instance size so user will be successful in running the application.
alexsin368
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed all comments
Signed-off-by: alexsin368 <[email protected]>
…pea-project-docs into val_updates_codegen
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
alexsin368
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed comments
mkbhanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.