Skip to content

Conversation

@alexsin368
Copy link
Collaborator

  • Remove steps to build images: just use docker compose to pull images instead
  • Add steps for running with vLLM and TGI
  • Update steps to validate microservices
  • Update steps for port forwarding and changing BACKEND_SERVICE_IP for UI to work
  • Fix grammar and improve wording

@alexsin368 alexsin368 added documentation Improvements or additions to documentation v1.3 labels Apr 16, 2025
@yinghu5 yinghu5 requested review from Copilot and yinghu5 April 16, 2025 02:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • tutorial/CodeTrans/CodeTrans_Guide.rst: Language not supported
Comments suppressed due to low confidence (1)

tutorial/CodeTrans/deploy/gaudi.md:95

  • The start command for the Gaudi deployment uses the 'intel/cpu/xeon' directory path, while the stop command later refers to 'intel/hpu/gaudi'. Please review and correct the directory path to ensure consistency for the Gaudi environment.
cd $WORKSPACE/GenAIExamples/CodeTrans/docker_compose/intel/cpu/xeon

@joshuayao joshuayao added this to OPEA Apr 16, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 16, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 16, 2025
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Signed-off-by: alexsin368 <[email protected]>
@alexsin368
Copy link
Collaborator Author

addressed all comments

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashahba ashahba merged commit e16f019 into opea-project:main Apr 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 18, 2025
@alexsin368 alexsin368 deleted the val_updates_codetrans branch April 22, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation v1.3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants