-
Notifications
You must be signed in to change notification settings - Fork 88
Update and simplify CodeTrans tutorials #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexsin368
commented
Apr 16, 2025
- Remove steps to build images: just use docker compose to pull images instead
- Add steps for running with vLLM and TGI
- Update steps to validate microservices
- Update steps for port forwarding and changing BACKEND_SERVICE_IP for UI to work
- Fix grammar and improve wording
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- tutorial/CodeTrans/CodeTrans_Guide.rst: Language not supported
Comments suppressed due to low confidence (1)
tutorial/CodeTrans/deploy/gaudi.md:95
- The start command for the Gaudi deployment uses the 'intel/cpu/xeon' directory path, while the stop command later refers to 'intel/hpu/gaudi'. Please review and correct the directory path to ensure consistency for the Gaudi environment.
cd $WORKSPACE/GenAIExamples/CodeTrans/docker_compose/intel/cpu/xeon
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
yinghu5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
mkbhanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
Signed-off-by: alexsin368 <[email protected]>
|
addressed all comments |
ashahba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!