Update and simplify DocSum tutorials #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexsin368
commented
Apr 16, 2025
alexsin368
commented
- Remove steps to build images: just use docker compose to pull images instead
- Add steps for running with vLLM and TGI
- Update steps to validate microservices
- Update steps for port forwarding and changing BACKEND_SERVICE_IP for UI to work
- Fix grammar and improve wording
Signed-off-by: alexsin368 <[email protected]>
alexsin368
requested review from
chensuyue,
chickenrae,
ftian1,
mkbhanda,
preethivenkatesh and
tomlenth
as code owners
Signed-off-by: alexsin368 <[email protected]>
mkbhanda
reviewed
Apr 17, 2025
Collaborator
mkbhanda
left a comment
mkbhanda
left a comment
There was a problem hiding this comment.
@alexsin368 could you have introduced a tab for the HW? There is so much repetition here between Gaudi and CPU. The only differences would have been which compose file to use to start and stop services. I know it is a pain, but longer term less to maintain. Please consider.
Signed-off-by: alexsin368 <[email protected]>
Collaborator
Author
|
@mkbhanda I've addressed all your comments and suggestions. You have a valid point about adding a tab for different hardware. However, for examples with multiple model serving options vLLM and TGI, we will end up with nested tabs which can make it not user friendly. A lot of logs are also different. |
lvliang-intel
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.