Skip to content

Conversation

@BTMuli
Copy link
Member

@BTMuli BTMuli commented Aug 29, 2025

Note

该PR仅将部分内容进行国际化,后续有待完善

  • 首页一级页面(未登录),包括右上登录浮窗
  • 搜索一级页面,不包括tag
  • 补充了设置页大部分未完善的国际化,不包括数据源刷新提示

@Him188
Copy link
Member

Him188 commented Aug 30, 2025

建议PR少量多次,好合并

@BTMuli BTMuli marked this pull request as ready for review September 2, 2025 06:08
@BTMuli BTMuli requested a review from Him188 September 2, 2025 06:08
@Him188 Him188 requested review from Copilot and removed request for Him188 September 3, 2025 18:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR internationalizes various scattered parts of the application, replacing hardcoded Chinese strings with localized string resources. The changes cover the home page (for non-logged-in users), search functionality, and incomplete internationalization in the settings pages.

  • Internationalized text in settings network and proxy configuration pages
  • Added localized strings for account-related UI elements and login/logout functionality
  • Implemented internationalization for search page UI elements and NSFW content handling

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ServerSelectionGroup.kt Replaces hardcoded Chinese strings with internationalized resources for server selection
ConfigureProxyGroup.kt Adds internationalization for proxy configuration UI text and status messages
DebugTab.kt Updates logout functionality to use shared account strings instead of debug-specific ones
SelfInfoBanner.kt Internationalizes login/register button text
ProfilePopupLayout.kt Adds internationalization for profile popup menu items and descriptions
BangumiAuthorizeLayout.kt Internationalizes login/register button in authorization flow
NsfwMask.kt Adds internationalization for NSFW content display controls
SelfAvatar.kt Internationalizes avatar menu items and logout confirmation dialog
SearchPageResultColumn.kt Adds internationalization for search result text and sorting options
SearchPage.kt Internationalizes search page UI elements like placeholder text and navigation
SearchFilter.kt Adds TODO comment for future internationalization of tag filters
FollowedSubjectsLazyRow.kt Internationalizes hint text for empty followed subjects
UserInfoRow.kt Internationalizes settings icon description
MainScreen.kt Internationalizes settings navigation item text
strings.xml files Adds new string resources for all supported locales (en, zh-CN, zh-TW, zh-HK)
Tag.kt Adds TODO comment for future internationalization of tag kinds
Comments suppressed due to low confidence (1)

app/shared/ui-exploration/src/commonMain/kotlin/ui/exploration/search/SearchPageResultColumn.kt:1

  • This import is no longer used after removing the itemKey usage. It should be removed to keep imports clean.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请确保简体中文部分与以前完全一致, 其他语言要对应简体中文的措辞方式

@BTMuli BTMuli requested a review from Him188 September 4, 2025 06:39
@Him188
Copy link
Member

Him188 commented Sep 11, 2025

有 conflict, 辛苦解决一下?

@BTMuli
Copy link
Member Author

BTMuli commented Sep 12, 2025

有 conflict, 辛苦解决一下?

已更新

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants