-
Notifications
You must be signed in to change notification settings - Fork 360
🌐 一些零散地方的国际化 #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌐 一些零散地方的国际化 #2442
Conversation
|
建议PR少量多次,好合并 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR internationalizes various scattered parts of the application, replacing hardcoded Chinese strings with localized string resources. The changes cover the home page (for non-logged-in users), search functionality, and incomplete internationalization in the settings pages.
- Internationalized text in settings network and proxy configuration pages
- Added localized strings for account-related UI elements and login/logout functionality
- Implemented internationalization for search page UI elements and NSFW content handling
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ServerSelectionGroup.kt | Replaces hardcoded Chinese strings with internationalized resources for server selection |
| ConfigureProxyGroup.kt | Adds internationalization for proxy configuration UI text and status messages |
| DebugTab.kt | Updates logout functionality to use shared account strings instead of debug-specific ones |
| SelfInfoBanner.kt | Internationalizes login/register button text |
| ProfilePopupLayout.kt | Adds internationalization for profile popup menu items and descriptions |
| BangumiAuthorizeLayout.kt | Internationalizes login/register button in authorization flow |
| NsfwMask.kt | Adds internationalization for NSFW content display controls |
| SelfAvatar.kt | Internationalizes avatar menu items and logout confirmation dialog |
| SearchPageResultColumn.kt | Adds internationalization for search result text and sorting options |
| SearchPage.kt | Internationalizes search page UI elements like placeholder text and navigation |
| SearchFilter.kt | Adds TODO comment for future internationalization of tag filters |
| FollowedSubjectsLazyRow.kt | Internationalizes hint text for empty followed subjects |
| UserInfoRow.kt | Internationalizes settings icon description |
| MainScreen.kt | Internationalizes settings navigation item text |
| strings.xml files | Adds new string resources for all supported locales (en, zh-CN, zh-TW, zh-HK) |
| Tag.kt | Adds TODO comment for future internationalization of tag kinds |
Comments suppressed due to low confidence (1)
app/shared/ui-exploration/src/commonMain/kotlin/ui/exploration/search/SearchPageResultColumn.kt:1
- This import is no longer used after removing the itemKey usage. It should be removed to keep imports clean.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/shared/app-lang/src/androidMain/res/values-zh-rCN/strings.xml
Outdated
Show resolved
Hide resolved
app/shared/ui-exploration/src/commonMain/kotlin/ui/exploration/search/SearchPageResultColumn.kt
Show resolved
Hide resolved
Him188
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请确保简体中文部分与以前完全一致, 其他语言要对应简体中文的措辞方式
app/shared/app-lang/src/androidMain/res/values-zh-rCN/strings.xml
Outdated
Show resolved
Hide resolved
|
有 conflict, 辛苦解决一下? |
已更新 |
Note
该PR仅将部分内容进行国际化,后续有待完善