Skip to content

Fixed the "Show More" button issue in the subject details page where the button was not responding correctly when clicked. #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeneralK1ng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed the "Show More" button issue in the subject details page where the button was not responding correctly when clicked. #2499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/shared/ui-subject/src/commonMain/kotlin/ui/subject/details/components/DetailsTab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,12 @@ private fun TagsList(
derivedStateOf {
when {
isExpanded -> allTags
allTags.size <= 6 -> allTags
else -> {
val filteredByCount = allTags.filter { it.count > 100 }
if (filteredByCount.size < ALWAYS_SHOW_TAGS_COUNT) {
allTags.take(ALWAYS_SHOW_TAGS_COUNT)
} else {
if (filteredByCount.size <= ALWAYS_SHOW_TAGS_COUNT) {
filteredByCount
} else {
allTags.take(ALWAYS_SHOW_TAGS_COUNT)
}
Comment on lines -270 to 276
Copy link
Contributor

@Mystery406 Mystery406 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉可以把这部分逻辑抽出来跟上面是否显示 hasMore 的逻辑匹配上，比如

val collapsedTags by remember { derivedStateOf { xxx } }
val hasMoreTags by remember { derivedStateOf { collapsedTags.size < allTags.size } }

}
}
Expand Down
Loading