Skip to content

fix: update @types/node version to 24.6.2 and set node engine requirement to 22 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Oct 2, 2025
Merged

fix: update @types/node version to 24.6.2 and set node engine requirement to 22 #458

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
a89861e
fix: update @types/node version to 24.6.2 and set node engine require…
mafreud Oct 2, 2025
2d7b35b
fix: remove Node.js version matrix and set fixed version to 22 in reu…
mafreud Oct 2, 2025
56579c9
fix: remove Node.js version matrix and set fixed version to 22 in Fir…
mafreud Oct 2, 2025
2b0c02a
fix: update @types/node to 24.6.2 and undici-types to 7.13.0 in packa…
mafreud Oct 2, 2025
4ad9a4c
fix: update Node.js setup to use .nvmrc for version management in CI …
mafreud Oct 2, 2025
d69fdb8
feat: add Firebase Functions deployment check workflow
mafreud Oct 2, 2025
a8f1d6b
fix: adjust indentation for consistency in Firebase Functions CI work…
mafreud Oct 2, 2025
b403abd
fix: clarify dependency installation steps in Firebase Functions CI w…
mafreud Oct 2, 2025
0e2f47f
fix: simplify dependency installation steps in Firebase Functions CI …
mafreud Oct 2, 2025
ebdb547
fix: correct syntax for dependency installation in Firebase Functions…
mafreud Oct 2, 2025
f283b55
fix: update dependency installation command for consistency in Fireba…
mafreud Oct 2, 2025
97b752f
fix: add directory listing step during dependency installation in Fir…
mafreud Oct 2, 2025
b6ea459
fix: add working directory output during dependency installation in F…
mafreud Oct 2, 2025
8cff1a3
fix: correct directory path for dependency installation in Firebase F…
mafreud Oct 2, 2025
9a1c507
fix: remove redundant commands and ensure working directory output du…
mafreud Oct 2, 2025
56aa4e5
fix: add directory listing and build step during dry-run check in Fir…
mafreud Oct 2, 2025
510175e
fix: add verbose flag to firebase-tools emulators:exec for better log…
mafreud Oct 2, 2025
fc06e30
fix: remove verbose flag from firebase-tools emulators:exec command
mafreud Oct 2, 2025
bc2190b
fix: reorganize build steps in Firebase Functions CI workflow for cla…
mafreud Oct 2, 2025
4886c2e
fix: update package dependencies and adjust Node.js engine version
mafreud Oct 2, 2025
a397c13
fix: remove redundant build steps for firebase-functions and github-a…
mafreud Oct 2, 2025
508796d
fix: add additional directory navigation and listing in CI workflow f…
mafreud Oct 2, 2025
efd164a
fix: remove unnecessary build command from Firebase emulator execution
mafreud Oct 2, 2025
5ce434a
fix: streamline build steps and improve emulator dry-run execution in…
mafreud Oct 2, 2025
0c99730
fix: simplify build commands for firebase-functions and github-apps i…
mafreud Oct 2, 2025
365165c
fix: add directory listing commands for clarity in emulator dry-run step
mafreud Oct 2, 2025
501a27f
fix: update TypeScript configuration for module compatibility and imp…
mafreud Oct 2, 2025
1ed2383
fix: reorder installation of dependencies for clarity in CI workflow
mafreud Oct 2, 2025
825b6b7
fix: reorder build steps for firebase-functions and github-apps in CI…
mafreud Oct 2, 2025
bab4f3f
fix: streamline dependency installation and build steps for clarity i…
mafreud Oct 2, 2025
bdefc16
fix: correct command syntax for emulator dry-run step in CI workflow
mafreud Oct 2, 2025
2f1a671
fix: update dry-run command in CI workflow for emulator to use echo
mafreud Oct 2, 2025
3485e2c
fix: simplify dry-run check command in CI workflow for firebase funct…
mafreud Oct 2, 2025
6173a77
fix: remove project flag from dry-run check command in CI workflow fo…
mafreud Oct 2, 2025
29d9790
fix: correct dry-run command syntax for emulator in CI workflow
mafreud Oct 2, 2025
1f9e271
fix: update dry-run command in CI workflow to remove unnecessary flag…
mafreud Oct 2, 2025
8625a2f
fix: update dry-run command in CI workflow to use echo instead of ls
mafreud Oct 2, 2025
f41ea62
fix: update dry-run command in CI workflow to include --non-interacti…
mafreud Oct 2, 2025
14d9860
fix: update dry-run command in CI workflow to include emulator execut…
mafreud Oct 2, 2025
25659ab
fix: streamline installation of dependencies for github-apps in CI wo…
mafreud Oct 2, 2025
1674a00
fix: add authentication step and deploy command for firebase function…
mafreud Oct 2, 2025
0bf1146
fix: escape quotes in deploy command for firebase functions in CI wor…
mafreud Oct 2, 2025
381f7bb
fix: update deploy step in CI workflow to set environment variables a…
mafreud Oct 2, 2025
e8d80fb
fix: add installation step for firebase tools and update deploy comma…
mafreud Oct 2, 2025
06a77e0
fix: add --inspect-functions flag to firebase emulators deploy command
mafreud Oct 2, 2025
08963fe
fix: add step to write emulator parameters for firebase functions dep…
mafreud Oct 2, 2025
36df913
fix: remove --inspect-functions flag from firebase emulators deploy c…
mafreud Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions ...b/workflows/verify-firebase-functions.yml → ...workflows/check-firebase-functions-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Verify Firebase Functions
name: Check Firebase Functions Deploy

on:
pull_request:
Expand All @@ -16,14 +16,12 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version-file: .nvmrc

- name: Install dependencies for firebase-functions
- run: npm ci

- name: Install dependencies for github-apps
working-directory: openci-runner/github-apps
run: npm ci
- name: Install dependencies
run: |
npm ci
npm ci --prefix ../github-apps

- uses: google-github-actions/auth@v2
with:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/firebase-functions-ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
matrix:
node-version: [20, 22]
defaults:
run:
working-directory: openci-runner/firebase/functions
Expand All @@ -33,7 +30,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: .nvmrc

- name: Install dependencies
run: npm ci
Expand All @@ -55,7 +52,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version-file: .nvmrc

- uses: google-github-actions/auth@v2
with:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/reusable-github-apps-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
matrix:
node-version: [20, 22]
defaults:
run:
working-directory: openci-runner/github-apps
Expand All @@ -21,7 +18,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: .nvmrc

- name: Install dependencies
run: npm ci
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
1 change: 1 addition & 0 deletions openci-controller.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"nextest",
"nodenext",
"nonexistentkey",
"nvmrc",
"octocrab",
"openci",
"plainaddress",
Expand Down
33 changes: 25 additions & 8 deletions openci-runner/firebase/functions/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openci-runner/firebase/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"devDependencies": {
"@types/supertest": "^6.0.3",
"@types/node": "^22.5.0",
"@types/node": "^24.6.2",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

@types/nodeのバージョンが不正です。

Node.js 22を使用している場合、@types/nodeのバージョンは^22.x.xである必要がありますが、^24.6.2が指定されています。これは以下の問題を引き起こす可能性があります：

  1. Node.js 24の型定義が存在しない（Node.js 24はまだリリースされていません）
  2. 型の不一致によるコンパイルエラーや実行時エラー

PRタイトルでは「update @types/node version to 24.6.2」となっていますが、おそらく22.6.2の誤記と思われます。

以下のdiffを適用して修正してください：

-		"@types/node": "^24.6.2",
+		"@types/node": "^22.6.2",

以下のスクリプトを実行して、@types/nodeの最新バージョンを確認してください：

🏁 Script executed:

#!/bin/bash
# @types/nodeの最新バージョンを確認
npm view @types/node versions --json | jq '.[-10:]'

# Node.js 22に対応する@types/nodeバージョンを確認
echo -e "\n=== Checking @types/node for Node.js 22 ==="
npm view @types/node@22 version

Length of output: 3993

@types/nodeのバージョン不整合

Firebase Functionsのpackage.jsonでエンジンにNode.js 22を指定していますが、@types/nodeが^24.6.2となっており型定義と実行環境が一致していません。^22.x.x系（例：^22.18.8）に戻してください。

-  "@types/node": "^24.6.2",
+  "@types/node": "^22.18.8",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@types/node": "^24.6.2",
"@types/node": "^22.18.8",
🤖 Prompt for AI Agents 
In openci-runner/firebase/functions/package.json around line 24, @types/node is
set to ^24.6.2 which mismatches the Functions engine (Node.js 22); change the
devDependency to a Node 22-compatible version such as ^22.18.8 (or ^22.x.x) to
align type definitions with the runtime, then run npm install (or update
package-lock.json) to apply the version change.

"firebase-functions-test": "^3.1.0",
"supertest": "^7.0.0",
"typescript": "^5.9.3",
Expand Down
2 changes: 1 addition & 1 deletion openci-runner/github-apps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@types/pg": "8.15.1"
},
"engines": {
"node": ">= 18"
"node": "22"
},
"type": "module"
}