Skip to content

refactor: simplify environment variable handling for Firebase deployment #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2025
Merged

refactor: simplify environment variable handling for Firebase deployment #462

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b07a81
refactor: simplify environment variable handling for Firebase deployment
mafreud Oct 3, 2025
2b7fe66
refactor: update Firebase deployment jobs for pull request handling
mafreud Oct 3, 2025
099ca2b
refactor: update deployment step name and .gitignore for production f…
mafreud Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions .github/workflows/github-apps-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,33 @@ jobs:
firebase-functions-tests:
uses: ./.github/workflows/reusable-firebase-functions-ci.yml

deploy-firebase-functions:
deploy-firebase-functions-dev:
if: github.event_name == 'pull_request'
needs: [github-apps-tests, firebase-functions-tests]
runs-on: ubuntu-latest
defaults:
run:
working-directory: openci-runner/firebase
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: .nvmrc

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.FIREBASE_SA_KEY_FOR_PREVIEW_FUNCTIONS }}

- name: Install dependencies
working-directory: openci-runner/firebase/functions
run: npm ci

- name: Deploy Functions (dev)
run: npx firebase-tools deploy --only functions --project ${{ secrets.FIREBASE_PROJECT_ID_FOR_PREVIEW_FUNCTIONS }}

deploy-firebase-functions-production:
if: github.event_name == 'push'
needs: [github-apps-tests, firebase-functions-tests]
runs-on: ubuntu-latest
defaults:
Expand All @@ -34,5 +60,5 @@ jobs:
working-directory: openci-runner/firebase/functions
run: npm ci

- name: Deploy Functions
run: npx firebase-tools deploy --only functions --project ${{ secrets.FIREBASE_PROJECT_ID }}
- name: Deploy Functions (dev)
run: npx firebase-tools deploy --only functions --project ${{ secrets.FIREBASE_PROJECT }}