-
Notifications
You must be signed in to change notification settings - Fork 1
Op 289 2 #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added Probot as a dependency in Firebase functions. - Updated Firebase functions to use Probot middleware for GitHub app integration. - Defined additional GitHub app secrets in Firebase functions. - Updated TypeScript configuration to support ES modules and added skipLibCheck. - Refactored GitHub app implementation to export as a function. - Updated tests to reflect changes in the app structure and dependencies. - Cleaned up package-lock.json by removing unnecessary nested dependencies. - Updated dependencies in GitHub apps to latest versions for better compatibility.
…deployment workflow feat: add "FUNCS" to workspace extensions for improved development experience
… Firebase function
…and remove unused variable in Firebase function
- Removed the existing GitHub app implementation from openci-runner/github-apps. - Added new implementation in openci-runner/firebase/functions/probot. - Updated test fixtures and test cases to reflect the new structure. - Deleted obsolete files related to the previous implementation.
…Firebase function
…b webhook function
…lient and eventsource dependencies
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughProbot execution updated to run via CLI entry point, pointing to ./lib/probot/index.js. The Probot app module now also provides a default export of appFn. A dev dependency on smee-client was added. No business logic changes were introduced. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant CLI as Probot CLI
participant App as Probot App (default export appFn)
participant GH as GitHub Webhooks
participant Smee as Smee Client (dev)
Dev->>CLI: npm start\n(probot run ./lib/probot/index.js)
CLI->>App: Load default export (appFn)
App-->>CLI: Initialize event handlers
rect rgba(200,230,255,0.2)
note over GH,Smee: Development forwarding
GH-->>Smee: Webhook events
Smee-->>CLI: Forwarded events (HTTP)
end
CLI->>App: Dispatch event
App-->>CLI: Handle event (success/error)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Comment |
Summary by CodeRabbit
新機能
リファクタリング
雑務