Skip to content

Conversation

mafreud
Copy link
Contributor

@mafreud mafreud commented Oct 5, 2025

Summary by CodeRabbit

  • 新機能

    • なし(挙動に目立った追加はありません)
  • リファクタリング

    • エクスポート方式を調整し、モジュールの互換性を向上
  • 雑務

    • 起動コマンドを更新し、起動時の安定性とログの一貫性を改善
    • 開発用ツールを追加し、Webhook 開発・テスト体験を向上

mafreud added 18 commits October 4, 2025 18:30
- Added Probot as a dependency in Firebase functions.
- Updated Firebase functions to use Probot middleware for GitHub app integration.
- Defined additional GitHub app secrets in Firebase functions.
- Updated TypeScript configuration to support ES modules and added skipLibCheck.
- Refactored GitHub app implementation to export as a function.
- Updated tests to reflect changes in the app structure and dependencies.
- Cleaned up package-lock.json by removing unnecessary nested dependencies.
- Updated dependencies in GitHub apps to latest versions for better compatibility.
…deployment workflow

feat: add "FUNCS" to workspace extensions for improved development experience
…and remove unused variable in Firebase function
- Removed the existing GitHub app implementation from openci-runner/github-apps.
- Added new implementation in openci-runner/firebase/functions/probot.
- Updated test fixtures and test cases to reflect the new structure.
- Deleted obsolete files related to the previous implementation.
Copy link

linear bot commented Oct 5, 2025

Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • openci-runner/firebase/functions/package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Probot execution updated to run via CLI entry point, pointing to ./lib/probot/index.js. The Probot app module now also provides a default export of appFn. A dev dependency on smee-client was added. No business logic changes were introduced.

Changes

Cohort / File(s) Summary
Probot runtime & tooling
openci-runner/firebase/functions/package.json
Start script changed from "npm run shell" to "probot run ./lib/probot/index.js"; added devDependency "smee-client" ^4.3.1.
Probot app exports
openci-runner/firebase/functions/probot/index.ts
Added default export: export default appFn; alongside existing named export; no logic changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant CLI as Probot CLI
    participant App as Probot App (default export appFn)
    participant GH as GitHub Webhooks
    participant Smee as Smee Client (dev)

    Dev->>CLI: npm start\n(probot run ./lib/probot/index.js)
    CLI->>App: Load default export (appFn)
    App-->>CLI: Initialize event handlers

    rect rgba(200,230,255,0.2)
    note over GH,Smee: Development forwarding
    GH-->>Smee: Webhook events
    Smee-->>CLI: Forwarded events (HTTP)
    end

    CLI->>App: Dispatch event
    App-->>CLI: Handle event (success/error)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

ぴょんと跳ねて、スタートの鐘🔔
シェルの道からプロボットへ直行
既定の出口、appFnもご挨拶
すみぃと連携、イベント届く
耳ぴくり、ログは静かに光る
今日もCI畑でにんじん一本🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive 提出されたタイトル「Op 289 2」は内部チケット番号のみを示しており、実際の変更内容(Firebase関数の start スクリプト更新や appFn のデフォルトエクスポート追加)をまったく説明していないため、何を行うプルリクエストか判別できません。 プルリクエストの主な変更点を短い文章で明確に示すタイトル(例:「Firebase 関数の start スクリプトを probot 実行に更新し、appFn をデフォルトエクスポートとして追加」)に変更してください。
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@mafreud mafreud merged commit cc8d44a into develop Oct 5, 2025
4 checks passed
@mafreud mafreud deleted the op-289-2 branch October 5, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant