Skip to content

Conversation

@mafreud
Copy link
Contributor

@mafreud mafreud commented Oct 9, 2025

Summary by CodeRabbit

  • Chores
    • Webhook処理の実行タイムアウトを300秒に延長し、重い処理や外部連携時の安定性を向上しました。
    • デプロイ用ワークフローを単一ランナーに切替え、CI 実行の安定性と予測性を改善しました。
  • Bug Fixes
    • タイムアウトによるリクエスト失敗を緩和し、処理の失敗率を低減しました。

@linear
Copy link

linear bot commented Oct 9, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Firebase Functions の githubWebhook ハンドラで onRequesttimeoutSeconds: 300 を追加してタイムアウトを延長しました。CI ワークフロー .github/workflows/reusable-deploy-firebase-functions.yml はマトリクスから単一の openci-runner-beta ランナーへ変更されました。その他のロジックや制御フローの変更はありません。

Changes

Cohort / File(s) Change summary
Firebase Functions
openci-runner/firebase/functions/src/index.ts
onRequest のオプションへ timeoutSeconds: 300 を追加し、githubWebhook 関数のタイムアウトを延長
CI workflow
.github/workflows/reusable-deploy-firebase-functions.yml
runs-on をマトリクス選択(ubuntu-latest, openci-runner-beta)から単一の openci-runner-beta に変更(マトリクスの削除)

Sequence Diagram(s)

(今回の変更はタイムアウト値と CI ランナー設定の更新で、制御フローの新規導入や変更がないためシーケンス図は省略します。)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

ピョンと伸びて、秒を増やすよ🐇
ウェブフックは待つ、300の優しさ
CI は一つの道を選び歩む
にんじん片手に、ログを眺める
さあデプロイ、跳ねて行こう!

Pre-merge checks and finishing touches and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed タイトルはGitHub Webhook関数にtimeoutSecondsを設定するという主要な変更点を簡潔に示しており、変更内容と完全に一致しているため適切です。
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch op-308
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch op-308

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1fdd781 and 8307b5f.

📒 Files selected for processing (1)
  • .github/workflows/reusable-deploy-firebase-functions.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/reusable-deploy-firebase-functions.yml

11-11: label "openci-runner-beta" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

@mafreud mafreud merged commit c3aba35 into develop Oct 10, 2025
7 of 10 checks passed
@mafreud mafreud deleted the op-308 branch October 10, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants