-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add guard action for narrowing using type predicates #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new guard action and corresponding type definitions to enable narrowing using type predicates in the transformation framework. Key changes include:
- Adding new API links and documentation for the guard action in markdown files.
- Defining and exporting new types and properties for GuardIssue and GuardAction across the API and type folders.
- Implementing the guard function in the library with associated tests covering functionality and type inference.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/src/routes/api/menu.md | Added menu links for guard and its related issues/actions. |
| website/src/routes/api/(types)/GuardIssue/* | Introduced new property definitions and documentation for GuardIssue. |
| website/src/routes/api/(types)/GuardAction/* | Added type properties and documentation for GuardAction. |
| website/src/routes/api/(actions)/guard/* | Created properties and docs for the guard action along with usage examples. |
| library/src/actions/guard/* | Implemented the guard function, interfaces, and tests ensuring correct behavior and type inference. |
commit: |
|
Thank you for working on this! I plan it for our v1.2 release. Feel free to mark it as ready once you are done. After that I will take over, review everything and merge it. |
|
found a fix (involving lots of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@fabian-hiller is attempting to deploy a commit to the Open Circle Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR should be ready now. I will merge it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 101 out of 101 changed files in this pull request and generated 1 comment.


fixes #1089