Skip to content

fix: allow 13-digit Visa numbers in credit card validator #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yslpn wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix: allow 13-digit Visa numbers in credit card validator #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion library/src/actions/creditCard/creditCard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,11 @@ describe('creditCard', () => {
});

test('for Visa', () => {
expectNoActionIssue(action, ['4242424242424242', '4000056655665556']);
expectNoActionIssue(action, [
'4242424242424242',
'4000056655665556',
'4007000000027',
]);
});

test('with space dividers', () => {
Expand Down
2 changes: 1 addition & 1 deletion library/src/actions/creditCard/creditCard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export interface CreditCardAction<
* Credit card regex.
*/
const CREDIT_CARD_REGEX =
/^(?:\d{14,19}|\d{4}(?: \d{3,6}){2,4}|\d{4}(?:-\d{3,6}){2,4})$/u;
/^(?:\d{13,19}|\d{4}(?: \d{3,6}){2,4}|\d{4}(?:-\d{3,6}){2,4})$/u;

/**
* Sanitize regex.
Expand Down
Loading