Skip to content

Implement code points validator #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tats-u wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement code points validator #888

tats-u wants to merge 8 commits into from

Conversation

@tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 20, 2024 •
edited
Loading

Fixes #875

Implemented based on graphemes validation.

@fabian-hiller fabian-hiller self-assigned this Oct 20, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Oct 20, 2024
@fabian-hiller
Copy link
Member

fabian-hiller commented Oct 20, 2024

Thank you for creating this PR! I will try to review and merge it in the next weeks. 🙏

@tats-u
Copy link
Contributor Author

tats-u commented Oct 22, 2024

I might export the implementation of _getCodePointCoun to other validators (e.g. Zod) in the future.

@fabian-hiller
Copy link
Member

fabian-hiller commented Oct 28, 2024

I just want to let you know that I am focusing on our v1 release first before reviewing this PR.

@tats-u
Copy link
Contributor Author

tats-u commented Oct 28, 2024 •
edited
Loading

That's not good news. I'll wait for v1.1.0.
And I want to get permission to publish _getCodePointCount as my independent package from you.
If that function is improved by others, I'll try to get permission from them or keep mine as is.

@fabian-hiller
Copy link
Member

fabian-hiller commented Oct 28, 2024

Yes, feel free to create your own package. No permission required.

@fabian-hiller fabian-hiller force-pushed the main branch 2 times, most recently from f41426c to d713dfe Compare January 4, 2025 00:55
@vercel
Copy link

vercel bot commented Apr 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valibot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2025 2:30pm

@tats-u
Copy link
Contributor Author

tats-u commented Apr 29, 2025

@fabian-hiller rebased to main (no additional changes)

@tats-u
Copy link
Contributor Author

tats-u commented Apr 29, 2025 •
edited
Loading

Fix done. Could you allow this PR to run CIs?

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 17, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/valibot@888

commit: abec9d1

@fabian-hiller
Copy link
Member

fabian-hiller commented Jun 17, 2025

Sorry for my late reply. 😐 I updated the branch and triggered CI.

@fabian-hiller fabian-hiller added this to the v1.2 milestone Jun 17, 2025
@vercel
Copy link

vercel bot commented Jul 5, 2025

@tats-u is attempting to deploy a commit to the Valibot Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fabian-hiller fabian-hiller

Labels

enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

maxCodePoints / minCodePoints (UTF-32 code points)

2 participants

@tats-u @fabian-hiller