✨ Expose ManagedCluster annotations during join via clusteradm flag #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new optional flag
--klusterlet-annotation
to theclusteradm join
command. With this flag, users can annotate ManagedClusters during the registration process.Example usage:
Multiple annotations can be set by passing the flag multiple times:
Since Klusterlet requires all annotations to have a prefix of
agent.open-cluster-management.io
, the command is set up to automatically prefix any key which does not have it. This will simplify the command for end-users. Both of the following uses are valid and will result in the same outcome:kubectl get managedclusters cluster1 -o yaml --context kind-clusteradm-e2e-test-hub | grep annotations -A 2 annotations: agent.open-cluster-management.io/key1: value1
This PR also adds an e2e test to ensure the annotations are correctly applied to the ManagedCluster.
Related issue(s)
Fixes #480