Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golangci-lint to v1.64.8 #347

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Upgrade golangci-lint to v1.64.8 #347

merged 2 commits into from
Mar 25, 2025

Conversation

yiraeChristineKim
Copy link
Contributor

@yiraeChristineKim yiraeChristineKim commented Mar 17, 2025 •
edited
Loading

@yiraeChristineKim yiraeChristineKim force-pushed the ACM-8341 branch 3 times, most recently from a265bff to 10baab1 Compare March 17, 2025 20:03
@yiraeChristineKim yiraeChristineKim marked this pull request as ready for review March 18, 2025 13:23
@openshift-ci openshift-ci bot requested review from dhaiducek and JustinKuli March 18, 2025 13:23
@yiraeChristineKim yiraeChristineKim changed the title Update golangci-lint to ACM-8341 Update golangci-lint Mar 18, 2025
dhaiducek
dhaiducek reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this--these look like some good changes!

@yiraeChristineKim yiraeChristineKim marked this pull request as draft March 18, 2025 16:53
@yiraeChristineKim yiraeChristineKim marked this pull request as ready for review March 19, 2025 13:20
@openshift-ci openshift-ci bot requested a review from gparvin March 19, 2025 13:20
dhaiducek
dhaiducek reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many great things there--thanks for handling all these changes!

JustinKuli
JustinKuli reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few new helpful test linters, I think! The switch statements are also a bit nicer than if else, in my opinion.

Were any of these changes automatic by the linter, or did you have to go through all of them (just to understand the required work on the other repositories).

@yiraeChristineKim yiraeChristineKim changed the title Update golangci-lint Upgrade golangci-lint Mar 19, 2025
@yiraeChristineKim yiraeChristineKim changed the title Upgrade golangci-lint Upgrade golangci-lint to v1.64.8 Mar 19, 2025
@yiraeChristineKim yiraeChristineKim force-pushed the ACM-8341 branch 2 times, most recently from 33b4dc0 to fe1f371 Compare March 19, 2025 17:54
JustinKuli
JustinKuli previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Looks great! Thanks for the iterations on the linter rules, and dealing with Dale and I's opinions 😆

I believe all of @dhaiducek 's comments are resolved, but I'm just holding it for him to have one last check.

dhaiducek
dhaiducek reviewed Mar 20, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2025
@yiraeChristineKim yiraeChristineKim force-pushed the ACM-8341 branch 2 times, most recently from bcbb035 to fbead67 Compare March 20, 2025 16:46
@yiraeChristineKim
Update golangci-lint to 1.64.8
ba969f3 
All above these version:
github.com/golangci/golangci-lint/cmd/[email protected]
github.com/daixiang0/[email protected]
sigs.k8s.io/kustomize/kustomize/[email protected]
gosec => 2.22.2
kustomize => 5.6

Fix unit test lint issues

Signed-off-by: yiraeChristineKim <[email protected]>
@yiraeChristineKim
Upgrade go to 1.23
d15a1e3 
Signed-off-by: yiraeChristineKim <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Mar 24, 2025
dhaiducek
dhaiducek approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

LGTM! Thanks for all your work and discussions through this!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a371489 into open-cluster-management-io:main Mar 25, 2025
15 checks passed
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaiducek dhaiducek dhaiducek approved these changes

@JustinKuli JustinKuli JustinKuli approved these changes

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@dhaiducek dhaiducek

@JustinKuli JustinKuli

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiraeChristineKim @dhaiducek @JustinKuli @openshift-merge-robot