-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 create migration cr after the cluster manager cr is applied #389
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 61.46% 61.55% +0.08%
==========================================
Files 133 133
Lines 14086 14100 +14
==========================================
+ Hits 8658 8679 +21
+ Misses 4674 4669 -5
+ Partials 754 752 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhujian <[email protected]>
8f2d98a
to
198e17b
Compare
To some extent, this PR #328 has already ensured the expected CRD DOES exist before creating a Migration CR.
|
this means we cannot remove webhooks or remove an api version in the same release with migration. I am not quite sure how to control this. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pull request is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the |
Summary
This PR will:
ObservedGeneration
field for the cluster manager Applied conditionApplied
condition is true and theObservedGeneration
==Generation
), then create the migration CRRelated issue(s)
Fixes #