Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 create migration cr after the cluster manager cr is applied #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhujian7
Copy link
Member

Summary

This PR will:

  • add the ObservedGeneration field for the cluster manager Applied condition
  • wait the current generation cluster manager is applied(Applied condition is true and the ObservedGeneration==Generation), then create the migration CR

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member Author

/cc @qiujian16 @elgnay @xuezhaojun

@openshift-ci openshift-ci bot requested review from elgnay and qiujian16 March 29, 2024 11:29
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.55%. Comparing base (ff77abd) to head (198e17b).
Report is 149 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   61.46%   61.55%   +0.08%     
==========================================
  Files         133      133              
  Lines       14086    14100      +14     
==========================================
+ Hits         8658     8679      +21     
+ Misses       4674     4669       -5     
+ Partials      754      752       -2     
Flag Coverage Δ
unit 61.55% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

this means we cannot remove webhooks or remove an api version in the same release with migration. I am not quite sure how to control this.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

This pull request is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added Stale and removed Stale labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants