Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support regex selector #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #

Signed-off-by: Qing Hao <[email protected]>
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoqing0110
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (2b86b8d) to head (08ce0ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/placement/helpers/clusters.go 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   63.64%   63.78%   +0.14%     
==========================================
  Files         182      183       +1     
  Lines       17634    17641       +7     
==========================================
+ Hits        11223    11253      +30     
+ Misses       5480     5460      -20     
+ Partials      931      928       -3     
Flag Coverage Δ
unit 63.78% <90.32%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metav1.LabelSelector `json:",inline"`

// +optional
RegexSelector map[string]string `json:"regexSelector,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider a CEL based selector, which could be more flexible.
e.g. could reference a score value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants