🌱 enable leader election of klusterlet-agent on single node managed cluster #695
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haoqing0110 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
275a62f
to
c0fa479
Compare
haoqing0110
changed the title
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
c0fa479
to
1d6e452
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 185 185
Lines 17765 17765
=======================================
Hits 11258 11258
+ Misses 5577 5576 -1
- Partials 930 931 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
1d6e452
to
39b75b5
Compare
…sters Signed-off-by: Qing Hao <[email protected]>
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
39b75b5
to
81e8c59
Compare
|
/assign @elgnay @qiujian16 |
|
/lgtm |
Summary
The leader election of the klusterlet-agent is disabled on the single node managed cluster to speed up the restart procedure. While it might cause that two pods with different configuration, such as images or bootstrap config, running at the same time. Some unexpected behavior happens in this situation, for example, when old and new agents both exist, they override hub-kubeconfig-secret with different value and trigger each other create csr constantly.
To fix those issues, it is necessary to enable the leader election of the klusterlet-agent on the single node managed cluster.
Related issue(s)
Fixes #