Skip to content

🌱 Improve logging in selectBootstrapKubeConfigs function. #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xuezhaojun
Copy link
Member

Summary

Improve logging in selectBootstrapKubeConfigs function by replacing index with bootstrapKubeConfig in error and info messages for better clarity.

…ndex with bootstrapKubeConfig in error and info messages for better clarity.

Signed-off-by: xuezhaojun <[email protected]>
@xuezhaojun
Copy link
Member Author

/assign @yanmxa

@xuezhaojun
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (672252f) to head (ee690e4).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registration/spoke/bootstrapkubeconfigs.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   63.86%   63.70%   -0.17%     
==========================================
  Files         193      192       -1     
  Lines       18663    18919     +256     
==========================================
+ Hits        11920    12052     +132     
- Misses       5763     5873     +110     
- Partials      980      994      +14     
Flag Coverage Δ
unit 63.70% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yanmxa
Copy link
Member

yanmxa commented Mar 18, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 18, 2025
@xuezhaojun xuezhaojun closed this Mar 18, 2025
@xuezhaojun xuezhaojun reopened this Mar 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b13cb4d into open-cluster-management-io:main Mar 18, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants