Skip to content

Conversation

qiujian16
Copy link
Member

No description provided.

Signed-off-by: Jian Qiu <[email protected]>
Copy link

netlify bot commented May 29, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit 18d4c65
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/683829088bf00b00081e9bcd
😎 Deploy Preview https://deploy-preview-482--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from dhaiducek and xuezhaojun May 29, 2025 09:29
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/assign @mikeshng

{{% /tab %}}
{{< /tabpane >}}

### Bootstrap a cluster provisioned by Cluster-API
Copy link
Member

@mikeshng mikeshng Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header is kind of confusing. This new section covers auto-register(?) which doesn't require any manual bootstrapping of the klusterlet. Maybe we should be moving the new content to a dedicated "Auto register" header instead.

Does this auto register still need clusteradm to run accept? If it doesn't, maybe move the new header to above "Install clusteradm CLI tool". If it does require clusteradm, then move the new header below "Install clusteradm CLI tool" but above "Bootstrap a klusterlet".

I am thinking the new header should be Auto-register a cluster provisioned by Cluster API then the rest of your content follows (which looks fine to me). Thanks.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants