add placement examples for addon template #514
Conversation
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/hold |
| - requiredClusterSelector: | ||
| labelSelector: | ||
| matchLabels: | ||
| local-cluster: "true" |
There was a problem hiding this comment.
Is auto-import of hub cluster as managed cluster (local-cluster) something we recently added to OCM-io?
I don't remember this being a default behaviour before.
There was a problem hiding this comment.
Thanks for pointing this out! Yes, local-cluster is not added, should not use it directly in doc.
haoqing0110
force-pushed
the
br_addontemplate-examples
branch
from
b2acbce to
335e15c
Compare
|
/assign @qiujian16 @yiraeChristineKim |
| group: example.open-cluster-management.io | ||
| resource: exampleconfigs |
There was a problem hiding this comment.
Instead of showing non-exist example resource, how about we change to
- group: addon.open-cluster-management.io
resource: addondeploymentconfigs
| supportedConfigs: | ||
| - group: addon.open-cluster-management.io | ||
| resource: addondeploymentconfigs | ||
| resource: addontemplates |
There was a problem hiding this comment.
same here keep addondeploymentconfigs but add addontemplates
There was a problem hiding this comment.
Thanks, update to use addondeploymentconfigs and addontemplates as examples, it's more friendly to users.
Signed-off-by: Qing Hao <[email protected]>
haoqing0110
force-pushed
the
br_addontemplate-examples
branch
from
335e15c to
3613e24
Compare
|
/unhold |
|
cc @qiujian16 plz help do a final review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit ad8d2cf
into
open-cluster-management-io:main
4 participants
No description provided.