WIP: Implement application discovery with Spring Netflix #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punycode
changed the title
|
SonarCloud Quality Gate failed.
|
The `DefaultCoffeeNetApplication` is a default implementation, that cannot instantiated or subclassed and is only constructable by a builder. We move the builder to the actual `CoffeeNetApplication` interface and hide the default implementation at the package level.
Since we may want to serialize the domain interfaces to JSON, we should add consistent naming for the resulting JSON keys emitted.
This adds the allowed authorities feature to `CoffeeNetApplication` instances. This is instantly deprecated, since we will use this only to temporarily add the previously present Eureka based application discovery service.
Those parameters are not available in JDK 8 and have been added later.
…to implementation
Similar to the previous service API in `CoffeeNetAppService#getApps(AppQuery)` this simple interface will allow filtering the applications. The implementation for those services will be part of another module.
This is based on the original implementation in the legacy CoffeeNet. It uses a Spring Cloud based `DiscoveryClient` and is not tied to a particular implementation like Eureka. This way it can be used with either Eureka or with a statically configured `SimpleDiscoveryClient`. Theoretically it could also use the Kubernetes based version, but this one does not really work for services exposed to the outside world.
…pplications This adds an instance of `CoffeeNetApplications` to the application context, if there is a discovery client available and the `rocks.coffeenet.platform.discovery` dependency has been added to your application.
punycode
force-pushed
the
spring-netflix-eureka
branch
from
a96b1ce to
5270b8a
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will adapt the previous mechanism for CoffeeNet application discovery to the current Spring Netflix stack, while trying to keep it hidden behind interfaces, that will let us replace the stack easily.
The associated issue is #69.