Correct the configuration of LLaVA-CoT #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennymckormick
pushed a commit
to TobiasLee/VLMEvalKit
that referenced
this pull request
Jan 1, 2025
kennymckormick
added a commit
that referenced
this pull request
Jan 1, 2025
* update vlrewardbench * pre-commit fix * formatter * [Improvement] Better `AUTO_SPLIT` and model split for InternVL2 * [Minor] Improve CC-OCR Import * [Model] Support QVQ * [Model] Update Molmo Eval to Match Official Implementation (#648) * add molmo prompts * fix lint format * [Fix] Refine Qwen-VL2 device assignment * [Fix] Fix RealWorldQA md5 * update MMMU_DEV_VAL tsv * [Fix] Fix confusing image width&height (#704) Co-authored-by: Yuan Ye <[email protected]> * Update llama_vision.py (#705) * [Fix] Fix Lint * Fix Lint * Fix Lint --------- Co-authored-by: kennymckormick <[email protected]> Co-authored-by: jamespark3922 <[email protected]> Co-authored-by: CMeteor <[email protected]> Co-authored-by: Yuan Ye <[email protected]> Co-authored-by: Guowei Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, we sincerely appreciate the work of VLMEvalKit and the tremendous contributions it has made to the entire VLM community! However, the current configuration of LLaVA-CoT (e.g., max_new_tokens) is incorrect, leading to significant deviations in the benchmark test results. This PR aims to correct the configuration of LLaVA-CoT.