Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## opencraft-release/palm.1 #9 +/- ##
============================================================
+ Coverage 86.95% 87.00% +0.04%
============================================================
Files 253 254 +1
Lines 4370 4400 +30
Branches 1105 1117 +12
============================================================
+ Hits 3800 3828 +28
- Misses 551 553 +2
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Agrendalath
requested changes
Mar 1, 2024
Comment on lines
+119
to
+137
| <small className="text-body pl-2 pr-0"> | ||
| {optional ? intl.formatMessage(messages.optionalCompletion) : ''} | ||
| </small> |
Member
There was a problem hiding this comment.
Let's move this to a Badge. The text here is related to grading, which is a separate mechanism.
Author
There was a problem hiding this comment.
Done. I added it as small text because I gelt the Badge overloads the webpage a bit. But maybe it's fine:
DanielVZ96
force-pushed
the
dvz/optional-completions
branch
from
ef661fd to
6d3359f
Compare
DanielVZ96
force-pushed
the
dvz/optional-completions
branch
from
57f0f6c to
0536b1b
Compare
DanielVZ96
force-pushed
the
dvz/optional-completions
branch
from
0536b1b to
1d42457
Compare
Member
|
Replaced by #88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements separating optional progress from normal progress, and also displaying optional chapters and sequences in the outline.
Testing instructions
follow the instructions from this PR: open-craft/openedx-platform#638
Private-ref: BB-8586