Trigger aggregator update signal#186
Open
qasimgulzar wants to merge 3 commits intoopen-craft:masterfrom
Open
Conversation
Trigger aggregator update signal
Author
|
@open-craft-grove could you please help reviewing this PR |
Agrendalath
requested changes
Feb 15, 2024
Member
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@qasimgulzar, is there a specific reason for using plain signals instead of openedx-events?
| else: | ||
| aggregation_data = [obj.get_values() for obj in updated_aggregators] | ||
| cur.executemany(INSERT_OR_UPDATE_AGGREGATOR_QUERY, aggregation_data) | ||
| AggregatorUpdate.send(sender=self.__class__, aggregation_data=aggregation_data) |
Member
There was a problem hiding this comment.
Isn't aggregation_data undefined when connection.vendor == 'sqlite'?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.